Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 23 Jun 2021 13:11:03 +0100
From:   Aaron Tomlin <atomlin@redhat.com>
To:     Rafael Aquini <aquini@redhat.com>
Cc:     linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: vmalloc: add cond_resched() in __vunmap()
Message-ID: <20210623121103.i2xpvhxqyf7wopl4@ava.usersys.com>
References: <20210622225030.478384-1-aquini@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="3bx5yvu2w757xdna"
Content-Disposition: inline
In-Reply-To: <20210622225030.478384-1-aquini@redhat.com>
Precedence: bulk


--3bx5yvu2w757xdna
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue 2021-06-22 18:50 -0400, Rafael Aquini wrote:
> Like in other range zapping routines that iterate over
> a large list, lets just add cond_resched() within __vunmap()'s
> page-releasing loop in order to avoid the watchdog splats.
>=20
> Signed-off-by: Rafael Aquini <aquini@redhat.com>
> ---
>  mm/vmalloc.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index a13ac524f6ff..cd4b23d65748 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -2564,6 +2564,7 @@ static void __vunmap(const void *addr, int dealloca=
te_pages)
> =20
>  			BUG_ON(!page);
>  			__free_pages(page, page_order);
> +			cond_resched();
>  		}
>  		atomic_long_sub(area->nr_pages, &nr_vmalloc_pages);
> =20
> --=20
> 2.26.3
>=20

Good catch.

Reviewed-by: Aaron Tomlin <atomlin@redhat.com>

--=20
Aaron Tomlin

--3bx5yvu2w757xdna
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEeQaE6/qKljiNHm6b4t6WWBnMd9YFAmDTJMoACgkQ4t6WWBnM
d9adUA//RZS30uRgLfgY43El1uG1oRgqrxUpEmqJrljrdAetNuuhOQZ+D2kX8Lir
vohwyAIvp8rhXVZCnmqNpwSnsfcNOg65jU3MaQteHjSrW6JmJ/+G+JBrbjcKYKcf
2BIhqf6VRRPBVJ3fnjXtg5FkZTQR/BfukLcXrQFDomeXlDVCU4IzB+9OMFrQlDag
OAHlwtgFI9nlAmhV+gEWl9kPWjaG7idj5U1/jgjQTeqcj1Wqk68msztbJCZs4hP/
BDCZcRyfWC0fpOzC/W01qzsmYtFacSQmS7rLOD7osKNgtN0aard7Po+qAI+Jvlnp
bbx/xGZaEQe/WcDacp28UXfAgKUTgHaE/pS/bLSWR9XktkUPQOZt6YhjygwZzIAE
r7SjAvUQwtqEn1RMsNP4Cp7a329ETn2rOUlu9+rYeQaO+8DrHmDvKcmIRkz+kpFK
OfjTiT6dxcUmuzd0dkPJ0F/jfWTYt82NN+HvsYc1Ql69fLUqIvM1wYIzJeeNesg6
Io1igNu6/QceVwXoGbsjSXLaPTuXxyiPxfGC8am7Ssre4j2/7hNEfYmAdf6MR6NR
t79lIOo47yXvI4591aXjigXtT288CCZafc0wXUlbVkWosQ1ircBWxGqzsGlGXCOO
5hTzUGoXHewhTsgrHw0ushszF7WJ/lzuujZGt43x4fXpkqWTe/M=
=UDj0
-----END PGP SIGNATURE-----

--3bx5yvu2w757xdna--