Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] staging: rtl8723bs: convert function to static
To:     Fabio Aiuto <fabioaiuto83@gmail.com>, gregkh@linuxfoundation.org
Cc:     Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <20210623130103.7727-1-fabioaiuto83@gmail.com>
From:   Hans de Goede <hdegoede@redhat.com>
Message-ID: <a5e755c3-48c9-40d4-fccb-1b9146fe762f@redhat.com>
Date:   Wed, 23 Jun 2021 15:08:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20210623130103.7727-1-fabioaiuto83@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 6/23/21 3:01 PM, Fabio Aiuto wrote:
> function chk_sta_is_alive() is used only inside core/rtw_ap.c
> so remove the prototype and convert it to static.
> 
> Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

> ---
>  drivers/staging/rtl8723bs/core/rtw_ap.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 23bbdf084631..3e2d8b735fc8 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -164,8 +164,7 @@ static void update_BCNTIM(struct adapter *padapter)
>  	pnetwork_mlmeext->IELength = offset + remainder_ielen;
>  }
>  
> -u8 chk_sta_is_alive(struct sta_info *psta);
> -u8 chk_sta_is_alive(struct sta_info *psta)
> +static u8 chk_sta_is_alive(struct sta_info *psta)
>  {
>  	sta_update_last_rx_pkts(psta);
>  
>