Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?iso-8859-1?Q?Christian_L=F6hle?= <CLoehle@hyperstone.com>
To:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        =?iso-8859-1?Q?Christian_L=F6hle?= <CLoehle@hyperstone.com>
CC:     "rafael@kernel.org" <rafael@kernel.org>
Subject: [PATCH] kobject: Safe return of kobject_get_path with NULL
Thread-Topic: [PATCH] kobject: Safe return of kobject_get_path with NULL
Thread-Index: AQHXaD5guylz4e+fzky/qfcToJhYzA==
Date:   Wed, 23 Jun 2021 14:47:35 +0000
Message-ID: <CWXP265MB2680094534A5559B0A904B76C4089@CWXP265MB2680.GBRP265.PROD.OUTLOOK.COM>
Accept-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?NuLa2C76zWYOwtzaAC/lckOg1ZDfJcIIRu5oBDdngEhTAy6a9NB/oDDo4h?=
 =?iso-8859-1?Q?K4vPyB2auuGnwEm/Dbg29sTifCZfvIFz99DfdQwAgN5ZuKGWM2flVDhwVh?=
 =?iso-8859-1?Q?jUr586cqHgMy/MrPl9bC+xzCCnK40CULEOfX0v/VhybumL7m/eXxbUCCFq?=
 =?iso-8859-1?Q?WdN5OScygdNH2QLGw9wTDlOuO1RgBUMUQ1myNPlnrM/K4NF6AOyEUD88AI?=
 =?iso-8859-1?Q?rgwxl7htvn/EJOtCjTvpKdWPwwNckJDb2TcqvkGxoGlMAXBtuonD0/CcZi?=
 =?iso-8859-1?Q?MQUyH/12jSe9N8yzEn/EhYUJyIATaXspq/LUvoaTnwlK9IftwwIEpHwtsk?=
 =?iso-8859-1?Q?k1tjg83W07eyGJamI9Q0u5elPBnrsncoBeToB0DmLqeZhIeL1qD81wBwHz?=
 =?iso-8859-1?Q?yOwbE1wodHfSVbmtChN1flUNkQ+xGnzqJ41ngL7hZlYN9VPDLb6QieXjU7?=
 =?iso-8859-1?Q?6Xc3EUiiKj0Se6MMIORadgjHo2JL0andk3+iZyYXkYZBGipM9mbJwcwX/T?=
 =?iso-8859-1?Q?gF7FiX3xuvsSQWcNHT79XpPDVjDqsBuEgypfM9Yaem2NDAwEWa0uicuaA9?=
 =?iso-8859-1?Q?SO0457mkjqJt1zxjNAv9YYaDo5vAbOc/NB0kevw6VlnoGW57NXqCf4MhKz?=
 =?iso-8859-1?Q?+cdFC6ebmHW/Rvw+wFLjYTZXNJJ3Y0cszJfmUgp2lcCKMvj1zwfRdQxzJ0?=
 =?iso-8859-1?Q?L9UILO59Po7nY9ODU/q1TlBd//XCJEwtQF8rYDvXJzav639Sp5wJRkE2Hm?=
 =?iso-8859-1?Q?fdlNJtxQiw/2yrDtrTKD3dQ/l46kn84S+kuCjKknGqLzEj9M2sHOed8ljX?=
 =?iso-8859-1?Q?8WlUhFc5MW7yItQNgpEyZ3QDL+yCGDTHLb07YfjG8+SF1ELH/Xz6+wtbfB?=
 =?iso-8859-1?Q?5qQt5HaRjGAlU3HB6eyN/OitNcDsDsqXH73qsUc+uS23QhV4RHfQ0ok8jZ?=
 =?iso-8859-1?Q?z1pMvKzcXY+vkAC/qB8smwohpmGwxWzJqrCZG+jNDzhrevsVcb9V3xvl6y?=
 =?iso-8859-1?Q?QjXn3G5j+lPqATXpOMVbotzZEXsqhD9lBMxY/V2efWALZ5XA3jaAzmxc01?=
 =?iso-8859-1?Q?Cr2jTA3TOd8LB6cYesckMqFpjCVun2R/SfybbPn0bKxWWQRYqNGgm1oLWh?=
 =?iso-8859-1?Q?CxQZ6cZFKvwXbEhy3WZLTUaomwI1MtPS2WUuX1GhvJxYsyaEcrZY2b4ZbK?=
 =?iso-8859-1?Q?AHbU48UihHWj3QX5GkO8CvA1N+aj3DTt0AkEzJwwCWeqZiRccU2tVVPTb3?=
 =?iso-8859-1?Q?ABw0Q3OuhULVryET72LA3ZQyg0Fx8HEbkkDKvIRIl1fIH7ypPyJ36rL6lV?=
 =?iso-8859-1?Q?SFf8q0fR3oBdkUS53CpVosy4THYlA7tC0AIsNWpkx9nheIg=3D?=
MIME-Version: 1.0
X-OriginatorOrg: hyperstone.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CWXP265MB2680.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ac332ea-f663-415d-fd11-08d93655d6d8
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2021 14:47:35.3464
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 86f203eb-e878-4188-b297-34c118c18b11
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7Ou7X38HYkM/pLSaHmaXXLgHMLN0fZ25b+eE52UP4qVk3L4eSaGtLawMPcTgcgqKwUSat0nXNx1312ERaY1RnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB3219
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: hyperstone.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Prevent NULL dereference within get_kobj_path_length

Calling kobject_get_path could provoke a NULL dereference
if NULL was passed. while fill_kobj_path will return
with a sane 0 for NULL, kobjet_get_path_length did not.

Signed-off-by: Christian Loehle <cloehle@hyperstone.com>
---
 lib/kobject.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/kobject.c b/lib/kobject.c
index ea53b30cf483..735159c13a94 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -130,6 +130,8 @@ static int get_kobj_path_length(struct kobject *kobj)
 {
 	int length = 1;
 	struct kobject *parent = kobj;
+	if (!kobj)
+		return 0;
 
 	/* walk up the ancestors until we hit the one pointing to the
 	 * root.
-- 
2.32.0

Hyperstone GmbH | Line-Eid-Strasse 3 | 78467 Konstanz
Managing Directors: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782