Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5799175pxj; Wed, 23 Jun 2021 09:10:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw83bqGds9NZnhfgMDpHuFhkc9A0f6UMFzY5J3Kb8ueM1AQ4x+mnHk5j3dSixTUt7hdz+pE X-Received: by 2002:a6b:720f:: with SMTP id n15mr215122ioc.209.1624464634343; Wed, 23 Jun 2021 09:10:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624464634; cv=none; d=google.com; s=arc-20160816; b=nls1W1S9JAsLgQum1kiTChl35MDJvTJHbgH5uL4sLnexLsOjagbzwLiqiKmzzNJdx2 qSYLjkvvEYNCh9bwa2tRfI8J0SwZ1Z2+mxhs26DSPdThgLqYLXT2VBUuBCtXpSHlOcBF oTwnKbeqODNC0Ph2VHxk8O+gUuWyM91UX2c2IH+Wk9odr4Udw87Eix7LzefnEUxygEid 8WEzGGw7PtKka0mGCtaMz5qGXqL+YVCvQT3TaCYjP40Lq/CnlxLOV7kXGBtVOfDo4Jpu oKsWLdOHgdlH8GS8pdF7lveE2YqTSc4NB70AYtRaiX9g1IIum98EUm2nhmqo4NyjuK/G 4CQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0ZH13kmUz7DY9DVjMS/RcIWsEBbY4rnnJMGNMTnu8YA=; b=oFBLLRrOp0kztpfnt81spS0BmkT/GgfO9BNpy8UpsvrW41wLXkMgnV+GD7StpAoMp+ MaHGr7WQWp1VGNivAUrs4d1gI6pGbriO2Kx/C/Ph2+ZzNbvOvC7EFPbElxZ45aq7QmDs Fe/zQYfXOsWK53rhxPCAXhi+41XFduiHane5xqr/j9YQN5aR9K5sYjuLRcV1/YlDS6Td zuZdIQUlw/k3iQdCfkG1DCUyoh4ZqvWiuXmc2UBZjbHczqtFf9zmV6Fmj6haafpEEmA4 sF9O8GaqdqoiaHmxzWzSztTMPr7BQSWBwfVesE1p+wXfdJtP8/uJirpF/8/wybeFiD6i 5nDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Gu6bEqeu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y5si356625ioq.102.2021.06.23.09.10.21; Wed, 23 Jun 2021 09:10:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Gu6bEqeu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229915AbhFWQLq (ORCPT + 99 others); Wed, 23 Jun 2021 12:11:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:50542 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229882AbhFWQLn (ORCPT ); Wed, 23 Jun 2021 12:11:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6530961002; Wed, 23 Jun 2021 16:09:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624464565; bh=thhgwnhMO2xnAWqL7Ceox1dUfMDGS5PkB8ZPYFsW+Fc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gu6bEqeuBDd6kTGAAeS5YwKMnpgcqWz9UE7gsSVW4/F0+fMWe8oQFI2UhkoY9qKM1 4Yg3QU1nggRKhyPNVrycrtp8teyKYZVI/q+XM16WX6MBmLdu8RcQpa5Vzj4KoH0YxO /+E4ys+ccn5pQZN/wT224ZRIgtqIh2DfPjth4o8LMnmRYjH4tzcCoaxjusrOYETv+L WAN5d8y4O9KnQ8KK3+RpT5Q9mj+aPp6oBqBcDCrnOOvd7aRYKXP0uWuoMxz66Z8DFi h9CbFmmBI8YFbm4JQhHprqZ2ysZA+8PYLKxj1r5W3iOT4bHDxsHSSL5pBdXQfRHiHk K1gZmYKZt+ZYw== From: Mark Brown To: linux-spi@vger.kernel.org, Ralf Schlatterbeck , Mirko Vogt , linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Maxime Ripard , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , Chen-Yu Tsai Cc: Mark Brown Subject: Re: [PATCH v2 1/1] spi: spi-sun6i: Fix chipselect/clock bug Date: Wed, 23 Jun 2021 17:08:50 +0100 Message-Id: <162446446389.55587.4675699927821368249.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210614144507.y3udezjfbko7eavv@runtux.com> References: <20210614144507.y3udezjfbko7eavv@runtux.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Jun 2021 16:45:07 +0200, Ralf Schlatterbeck wrote: > The current sun6i SPI implementation initializes the transfer too early, > resulting in SCK going high before the transfer. When using an additional > (gpio) chipselect with sun6i, the chipselect is asserted at a time when > clock is high, making the SPI transfer fail. > > This is due to SUN6I_GBL_CTL_BUS_ENABLE being written into > SUN6I_GBL_CTL_REG at an early stage. Moving that to the transfer > function, hence, right before the transfer starts, mitigates that > problem. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: spi-sun6i: Fix chipselect/clock bug commit: 0d7993b234c9fad8cb6bec6adfaa74694ba85ecb All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark