Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 15/54] KVM: nSVM: Add a comment to document why nNPT uses
 vmcb01, not vCPU state
To:     Sean Christopherson <seanjc@google.com>
Cc:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Yu Zhang <yu.c.zhang@linux.intel.com>,
        Maxim Levitsky <mlevitsk@redhat.com>
References: <20210622175739.3610207-1-seanjc@google.com>
 <20210622175739.3610207-16-seanjc@google.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <b759e31b-6269-a401-9fbb-49227b8be009@redhat.com>
Date:   Wed, 23 Jun 2021 19:06:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20210622175739.3610207-16-seanjc@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 22/06/21 19:57, Sean Christopherson wrote:
> +	/*
> +	 * L1's CR4 and EFER are stuffed into vmcb01 by the caller.  Note, when
> +	 * called via KVM_SET_NESTED_STATE, that state may_not_  match current
> +	 * vCPU state.  CR0.WP is explicitly ignored, while CR0.PG is required.
> +	 */

"stuffed into" doesn't really match reality of vmentry, though it works 
for KVM_SET_NESTED_STATE.  What about a more neutral "The NPT format 
depends on L1's CR4 and EFER, which is in vmcb01"?

Paolo