Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v38 1/4] scsi: ufs: Introduce HPB feature
To:     daejun7.park@samsung.com, Greg KH <gregkh@linuxfoundation.org>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "huobean@gmail.com" <huobean@gmail.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>
Cc:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        JinHwan Park <jh.i.park@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        Dukhyun Kwon <d_hyun.kwon@samsung.com>,
        Keoseong Park <keosung.park@samsung.com>,
        Jaemyung Lee <jaemyung.lee@samsung.com>,
        Jieon Seol <jieon.seol@samsung.com>
References: <20210616070700epcms2p734db9b60e13229696fb3cda5f69e210f@epcms2p7>
 <CGME20210616070700epcms2p734db9b60e13229696fb3cda5f69e210f@epcms2p4>
 <20210616070812epcms2p4650ce5cd78056dce9162482e59bb74dd@epcms2p4>
From:   Bart Van Assche <bvanassche@acm.org>
Message-ID: <5a71d4c3-2f1f-3c85-eb90-381775e7030e@acm.org>
Date:   Wed, 23 Jun 2021 11:13:19 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210616070812epcms2p4650ce5cd78056dce9162482e59bb74dd@epcms2p4>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/16/21 12:08 AM, Daejun Park wrote:
> +What:		/sys/class/scsi_device/*/device/unit_descriptor/hpb_pinned_region_start_offset
> +Date:		June 2021
> +Contact:	Daejun Park <daejun7.park@samsung.com>
> +Description:	This entry shows the start offset of HPB pinned region.
> +
> +		The file is read only.
> +
> +What:		/June/class/scsi_device/*/device/unit_descriptor/hpb_number_pinned_regions
> +Date:		March 2021

Please change /June into /sys and "March 2021" into "June 2021".

> @@ -7094,6 +7119,7 @@ static int ufshcd_host_reset_and_restore(struct ufs_hba *hba)
>  {
>  	int err;
>  
> +	ufshpb_reset_host(hba);
>  	/*
>  	 * Stop the host controller and complete the requests
>  	 * cleared by h/w

Shouldn't the ufshpb_reset_host() call occur under the comment instead
of above?

Thanks,

Bart.