Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v38 3/4] scsi: ufs: Prepare HPB read for cached sub-region
To:     daejun7.park@samsung.com, Greg KH <gregkh@linuxfoundation.org>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "huobean@gmail.com" <huobean@gmail.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>
Cc:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        JinHwan Park <jh.i.park@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        Dukhyun Kwon <d_hyun.kwon@samsung.com>,
        Keoseong Park <keosung.park@samsung.com>,
        Jaemyung Lee <jaemyung.lee@samsung.com>,
        Jieon Seol <jieon.seol@samsung.com>
References: <20210616070700epcms2p734db9b60e13229696fb3cda5f69e210f@epcms2p7>
 <CGME20210616070700epcms2p734db9b60e13229696fb3cda5f69e210f@epcms2p8>
 <20210616070913epcms2p83805028905f46225a65cc71678cddde7@epcms2p8>
From:   Bart Van Assche <bvanassche@acm.org>
Message-ID: <468d63c0-f902-efc2-17d7-5f4321806ca6@acm.org>
Date:   Wed, 23 Jun 2021 11:17:05 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210616070913epcms2p83805028905f46225a65cc71678cddde7@epcms2p8>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/16/21 12:09 AM, Daejun Park wrote:
> +	if (blk_rq_is_scsi(cmd->request) ||
> +	    (!ufshpb_is_write_or_discard(cmd) &&
> +	    !ufshpb_is_read_cmd(cmd)))
> +		return;

If this patch series is reposted, please fix the indentation of
"!ufshpb_is_read_cmd(cmd)".

Thanks,

Bart.