Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 25/54] KVM: x86/mmu: Add helpers to query mmu_role bits
To:     Sean Christopherson <seanjc@google.com>
Cc:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Yu Zhang <yu.c.zhang@linux.intel.com>,
        Maxim Levitsky <mlevitsk@redhat.com>
References: <20210622175739.3610207-1-seanjc@google.com>
 <20210622175739.3610207-26-seanjc@google.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <1babfd1c-bee1-12e5-a9d9-9507891efdfd@redhat.com>
Date:   Wed, 23 Jun 2021 22:02:11 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20210622175739.3610207-26-seanjc@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 22/06/21 19:57, Sean Christopherson wrote:
> +static inline bool is_##reg##_##name(struct kvm_mmu *mmu)	\

What do you think about calling these is_mmu_##name?  The point of 
having these helpers is that the register doesn't count, and they return 
the effective value (e.g. false in most EPT cases).

Paolo

> +{								\
> +	return !!(mmu->mmu_role. base_or_ext . reg##_##name);	\
> +}
> +BUILD_MMU_ROLE_ACCESSOR(ext,  cr0, pg);
> +BUILD_MMU_ROLE_ACCESSOR(base, cr0, wp);
> +BUILD_MMU_ROLE_ACCESSOR(ext,  cr4, pse);
> +BUILD_MMU_ROLE_ACCESSOR(ext,  cr4, pae);
> +BUILD_MMU_ROLE_ACCESSOR(ext,  cr4, smep);
> +BUILD_MMU_ROLE_ACCESSOR(ext,  cr4, smap);
> +BUILD_MMU_ROLE_ACCESSOR(ext,  cr4, pke);
> +BUILD_MMU_ROLE_ACCESSOR(ext,  cr4, la57);
> +BUILD_MMU_ROLE_ACCESSOR(base, efer, nx);
> +
>   struct kvm_mmu_role_regs vcpu_to_role_regs(struct kvm_vcpu *vcpu)