Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5968212pxj; Wed, 23 Jun 2021 13:08:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwTSaI3rx54FwvBXyNJa7vnRxniyjDjheiR8CfGWORpytz/PrVqJVfbLMgxdbhgY6QGGQq X-Received: by 2002:a50:9e6b:: with SMTP id z98mr2141291ede.210.1624478892492; Wed, 23 Jun 2021 13:08:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624478892; cv=none; d=google.com; s=arc-20160816; b=bPeiSzr6H/Udvwdqzi7DaGgmhYvp8UIQdMdvDu7nd6tcq2FNQQxoarwmeCNuTjM0uf CGPR3VtnmhrD74t0YQn/3YNJIQEsJplrTRxwxsBuaTBZp4cG1PchOjux/qOAgQEluRSv ZZ3zMJkO5zvMhXh5E9F2dyj1IdsedBUq9qMq2AbCoRGHJzm50Rw91+A+jryFG8S5tscM Rj6InnLCuF2G76R1hwy8dWPN4rQ7AloC5MhNS/hR6MrsYnrx6Z9QzqmivIeAfobHqoeq qO54/MmKi8L+Jbw8X9mS1BwscKeGFUuZHTXPingOqPH/heXQwScPgULtQnP4TR7X0TaT Q8QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=jZtnIba38VOxOdV7QZ8WCZ06ktsu2UfEmSyMUoRu06c=; b=GEs+oqSHD6kaziPsMN5iEQRKS9msu0Fu0AVROTYIV+Fb8eopFxQR2Z/fBCyQfy1A4F n1tx9kXOe9IQSpXGEFrVdMbtQGtT0Y8F7UvSC16SHUene/q8fSpUK+MTSAgvLj4l1s96 uFfVDqnpoJNRavXsWfyw4vLyFP+QduudO5NqD8K/83d22/eVRJ0yJKZ6U2VGvhCB8JjZ 8YTrudX47I1POx9s0HAcQE5+xnNtvp20AoNhRCoSm4sMC8fI7spoTJvCvCpbMrDC23CP mySn25bGF3E9btAKO4YpWpAm7Tbwy2ykHgUFMmLOnzSD/T7YpH37y4ZS7Xvs1eXsmBmL pH3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a24si819077edm.212.2021.06.23.13.07.25; Wed, 23 Jun 2021 13:08:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229930AbhFWUIF (ORCPT + 99 others); Wed, 23 Jun 2021 16:08:05 -0400 Received: from mail-pl1-f170.google.com ([209.85.214.170]:39885 "EHLO mail-pl1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbhFWUID (ORCPT ); Wed, 23 Jun 2021 16:08:03 -0400 Received: by mail-pl1-f170.google.com with SMTP id d1so1102022plg.6; Wed, 23 Jun 2021 13:05:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jZtnIba38VOxOdV7QZ8WCZ06ktsu2UfEmSyMUoRu06c=; b=pXXLN67faVkdwas1SiGqGAFbOG5A2cta+W2saEHzE8Ldmj6sZ01FnNa6n6LXUjn7Qf WlyzHomBSjZaJUZoiSoLJkYG2hCzAGtx8D56lvNUIz3IsaUpK5TrBDYeWsYuMTPKqoLN hIxu7K/U0UZBCiVdZTT6XiosLcgyiVHPclMdQ/WITSJa5m1C9tBoDI7PMe5TzGSnd3W8 0r2twGwsXD9caPF+TZv/cTzRxUbuedLonbiQweckztmSq0J6Lnip+/tphbknl5XoSGxd Au0IqYtf1+P8ItO/UrEvrr8vI3XUXvy/rEgHCqG7hruQzDUOMXKd1I8+9O8I8bM29kKh QKfw== X-Gm-Message-State: AOAM5309roVKf9jQbC6ktKT/hSboXP5V1NeNuMTkiwn/mdUeBDgwLZP7 TbgtepOZ8J/DQgR8T7phCfZo/QBH0/DHTQ== X-Received: by 2002:a17:902:7241:b029:126:aa2b:a0d1 with SMTP id c1-20020a1709027241b0290126aa2ba0d1mr1287075pll.51.1624478744120; Wed, 23 Jun 2021 13:05:44 -0700 (PDT) Received: from [192.168.3.217] (c-73-241-217-19.hsd1.ca.comcast.net. [73.241.217.19]) by smtp.gmail.com with ESMTPSA id h27sm655632pfr.171.2021.06.23.13.05.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jun 2021 13:05:43 -0700 (PDT) Subject: Re: [PATCH v4 01/10] scsi: ufs: Rename flags pm_op_in_progress and is_sys_suspended To: Can Guo , asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, ziqichen@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com Cc: Andy Gross , Bjorn Andersson , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , Jaegeuk Kim , Adrian Hunter , Kiwoong Kim , Satya Tangirala , "open list:ARM/QUALCOMM SUPPORT" , open list References: <1624433711-9339-1-git-send-email-cang@codeaurora.org> <1624433711-9339-2-git-send-email-cang@codeaurora.org> From: Bart Van Assche Message-ID: <1c5db457-ee87-2308-15f5-5dad49508f10@acm.org> Date: Wed, 23 Jun 2021 13:05:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1624433711-9339-2-git-send-email-cang@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/23/21 12:35 AM, Can Guo wrote: > Rename pm_op_in_progress and is_sys_suspended to wlu_pm_op_in_progress and > is_wlu_sys_suspended accordingly. Hi Can, My understanding is that power management operations must be submitted to one particular UFS WLUN (hba->sdev_ufs_device). That makes the "wlu_" part of the new names redundant. In other words, I like the current names better than the new names. Unless if I missed something, consider dropping this patch. Thanks, Bart.