Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5997184pxj; Wed, 23 Jun 2021 13:55:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxo3P8Xbq1kwQ6zCLzCcCKABDFh0+3E9sN6KRvQzB/K65WXB7KtU20sBv8UPzG2VqUmKXLd X-Received: by 2002:a17:907:3da9:: with SMTP id he41mr1856643ejc.231.1624481712990; Wed, 23 Jun 2021 13:55:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624481712; cv=none; d=google.com; s=arc-20160816; b=0GnQ8Zu+suirIZIfpH1antZ7Bz+FwGkz9/gtwvbU0pqWN/hD9Czvd935ccohLaBs0o tt+I8s/2QSgbyoQDzcSmsbPfpk4RkAQDe2e4YPRotz+ugkOVMBvTwMQYMShBIieOdItQ ZB9JVqghIExQJI19DrRxW6P6Ybi50W4EoVGGrTk2yVwpeg7zwDw7ZgIh9BrMKth7JdNR 5lRP8rnM1IJrOrS6vrah1I4lBSKYHle5/wHZV/hnd16+Atu3seMVzj5oTMCqFwtd+xas Y4MhVQf8J2Gyyn9KTJFXu8+/SDunRLLVjt1TLQoNqo3IZ20v3JTALH2p3mtGZfZXkBAo gHOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Y36xbe3WJsujVSzScEvLHjGt0hwiw4fc3JAqaosgr04=; b=DOAYq/S2L3dBYIy95Rmj6aacOt24Hz953VgRNw2B1Nl3QHcKej0vARqWWTgH9iAP3T uDrPiR1+GQqWkpPcJyI1LZdnTHx+SnQQ180gTFDrGwuiryAc6Gyja/CNPr/zeoJCRWwn oCzgCKNqUOtiHFcC+2kFaS5ts0s4mdVz8AFcQ+zJ715dsOiFwtXINvKrPbFcC0t6kQ6v TDR3ui6Gt40jbJ88TE1HiYbaIj5AcUUAE/wjJotwiemp4EK9izVHmDKhYcyGFwxJn8Zy 9K/FbOWJR/8ryBE/9KlDpVDM+PpImuH0QpdoMXBSAPtGN2kz+Qe/FiKbhGdqlWQuPBzw QHhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=cDYjZBjE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id my4si687979ejc.337.2021.06.23.13.54.49; Wed, 23 Jun 2021 13:55:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=cDYjZBjE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229933AbhFWUzl (ORCPT + 99 others); Wed, 23 Jun 2021 16:55:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbhFWUzj (ORCPT ); Wed, 23 Jun 2021 16:55:39 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 519FDC061787 for ; Wed, 23 Jun 2021 13:53:16 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id d1so1160456plg.6 for ; Wed, 23 Jun 2021 13:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Y36xbe3WJsujVSzScEvLHjGt0hwiw4fc3JAqaosgr04=; b=cDYjZBjEqPIoMziHRVH86hrF5R4dCBqimcc/4MMEewnm6OVZG7u4FHJJr5+UXMdjuZ 5THc0L3XBAsJ3I7WmIB8eXt5sCYKPpvEV27YOOMpMi6ulkyhvREvyr3pf1HiHSkgQpaj tZzfjhV63Re+3um7G/2wJ5Fwubfr+rkXM8iJHY33Vc2xVy/WgkuGBd/ZfhxYRP7TNu3O 7uxLrCDglCSAdS1B38T2HpgTXu0YKBRm/9JJOmuaXIK5UROHlQqghiSb+zidvWSOAvHm uolucEcmV1uvmyuiG70LAArRx7XSXoHClFlvszof0izI0HI4xqkU2jZQZ9aGmKg/5r8i 1evg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Y36xbe3WJsujVSzScEvLHjGt0hwiw4fc3JAqaosgr04=; b=f/Ght+4vhZ/5V2Ws0rnbJxdhznm+GRgoChu1wTvuN0AqN/vhNegSw93tfa/fpQneED S8lzckn86RCONcMn8dwt85ASrESMuVixhOuBIm1xbLfQgTOjFmPaIQly9P99RxMx8c3b tJOtOO7rx+N7WmJaFpTmDyrvP8ltbS0XZ9mQ17F9T1nM1hHO9cg7B48eK+pKLAFrcfk0 mFVD++wLWM8qFm/vzRqnpCy5SSCTH07bhiZNrsOn5eXPSIGEGgASpR2VtAw02khTtBga +hCAhinof+afiop+T5yvO7VL+R8G84GdJpEdsdU58jt3onoyYQTLKcXgkY1HPjPz/8M/ T/Mg== X-Gm-Message-State: AOAM530x2/qyn4i5x93/2Nf2XDPWR6qn5njsP+MFALx9op7Nq/MONHjX kbts8iS5LBLYbWnLj1yKDt0p+A== X-Received: by 2002:a17:90a:b390:: with SMTP id e16mr1530112pjr.197.1624481595429; Wed, 23 Jun 2021 13:53:15 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id d13sm646515pfn.136.2021.06.23.13.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jun 2021 13:53:14 -0700 (PDT) Date: Wed, 23 Jun 2021 20:53:11 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Yu Zhang , Maxim Levitsky Subject: Re: [PATCH 41/54] KVM: x86/mmu: Consolidate reset_rsvds_bits_mask() calls Message-ID: References: <20210622175739.3610207-1-seanjc@google.com> <20210622175739.3610207-42-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 23, 2021, Paolo Bonzini wrote: > On 22/06/21 19:57, Sean Christopherson wrote: > > Move calls to reset_rsvds_bits_mask() out of the various mode statements > > and under a more generic !CR0.PG check > > CR0.PG=1, not =0. It's always some mundane detail!