Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 25/54] KVM: x86/mmu: Add helpers to query mmu_role bits
To:     Sean Christopherson <seanjc@google.com>
Cc:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Yu Zhang <yu.c.zhang@linux.intel.com>,
        Maxim Levitsky <mlevitsk@redhat.com>
References: <20210622175739.3610207-1-seanjc@google.com>
 <20210622175739.3610207-26-seanjc@google.com>
 <1babfd1c-bee1-12e5-a9d9-9507891efdfd@redhat.com>
 <YNOd/0RxSnqmDBvd@google.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <1c1cc822-4604-9e04-dd4c-e5005bfee7c5@redhat.com>
Date:   Wed, 23 Jun 2021 22:53:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <YNOd/0RxSnqmDBvd@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 23/06/21 22:47, Sean Christopherson wrote:
>> What do you think about calling these is_mmu_##name?  The point of having
>> these helpers is that the register doesn't count, and they return the
>> effective value (e.g. false in most EPT cases).
>
> I strongly prefer to keep <reg> in the name, both to match the mmu_role bits and
> to make it a bit more clear that it's reflective (modified) register state, as
> opposed to PTEs or even something else entirely.  E.g. I always struggled to
> remember the purpose of mmu->nx flag.

No problem.  I do disagree that it's register state ("modified" seems to 
be more than a parenthetical remark), but not enough to argue about it 
and even less to do the work to rename the accessors.

Paolo