Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp51864pxj; Wed, 23 Jun 2021 15:25:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhKEF/WAFiGuoRh5me454gc5zL8ciwLofXf4Gb9M5t2DzyhpYxchEp0tPvK0I7RI2Tcw8B X-Received: by 2002:a17:906:4b0a:: with SMTP id y10mr2206643eju.388.1624487125764; Wed, 23 Jun 2021 15:25:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624487125; cv=none; d=google.com; s=arc-20160816; b=GQUbfjU2KUz+60zhqocSPPDWa8LzwQQuhRRIbX3t0ou57Qye4/EIyORQSVQSXCHpUM BLm03J4U1WBN2DxXPaaDkZGyj89bfPCIKmOnWziEe65FRI/ejfVTIDY0cKS4+eQvXJbw +CnW0+UAEZq51P031ieX9qa9Lz/BWrPymoXXAbfNKXaBwCxv331OsBz8fue9mMGdyPiR orixJzOR3e4YeQgdYXWfN45RGG0bonMJJa6MHygOEwsMra1C1PmYVWTnq/2lUKFBhXLj ulW57Z4OMSO8HTlTD2LdK6H6WCk10QPEB/YVKFt1Xu7BB2su1MJDGSGAX1Ymi5anWu8x 3YOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :to:subject:dkim-signature; bh=0l0wLNR77GMohwjNSfFqVBgcOwDqqJnWYBylz7PW6SQ=; b=vJ6yDNAId3t7PFcY7rmkGoJZ31Jmz4Zdiy8zql6F8o97lu+up1Z48kfu1bOABVn/qB kIeVxG7Fh8i72G+9x0BPT65DbE024cPNrIqTZ1hv2Cucl7Ax5Sps4mjxYgtOjFRrHd1v B1MI1YZwXgCiEJQOYpJzfqzS8b87nlqNY6rBzFzcDCRGqOZRNY/Sl+1txOg2sU6trjQo dEOooL7yFahxyS1KH1CNDpcvDKFNopnVA9QUiN0ZwSvF2LevFlPTbElbUYkhg0JLv7YD GHFr186wqEXZDQaOjcp7x/j0t+fSi4uZSnBap8J6aDURCTli331DYj7IVf3LleICwXmz 5BPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=ZQv2q8CH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hz10si791067ejc.378.2021.06.23.15.25.02; Wed, 23 Jun 2021 15:25:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=ZQv2q8CH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229873AbhFWW0X (ORCPT + 99 others); Wed, 23 Jun 2021 18:26:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229758AbhFWW0W (ORCPT ); Wed, 23 Jun 2021 18:26:22 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A180C061574 for ; Wed, 23 Jun 2021 15:24:04 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id g22so5466354iom.1 for ; Wed, 23 Jun 2021 15:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=0l0wLNR77GMohwjNSfFqVBgcOwDqqJnWYBylz7PW6SQ=; b=ZQv2q8CHfpxTd+1bctfkF5Og6+VlNNcZTpi2VJefL0TsTwN/I26TnK24eTRAZ5XmlT KD1byGLkKBqLsNPcJdKlPnpISMiDNDUqFMVpLRRDb4ctE7oXKuRBydG/Y8tOPTCm308U NP+97iKmn3SK7YAHQyH7nV3rXj7f7k+o3RQ6SCX7cGyRyzEYg1xTvRujf2AJXHCv7s8S IGz76ZZiNPIbVi+6jlK3oMtY71mrkpU7FpVq/NLkJtzTBtgwz7QRacVr+ZWMmGGVCCS2 gKpAYCXUvAj7gFOl+NcetYvmd7FtCgmmICq+T+QNc8bsMsfN6zo3keNnkd72hdBiYvqy 8qvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0l0wLNR77GMohwjNSfFqVBgcOwDqqJnWYBylz7PW6SQ=; b=ZuRjsT4BYPnyrcEfZqoYQvDDjTWeY4aPs/XgcQB5N1yKyhS67HlgjboEKThcohu0do yoeLITRy3c9bCDpVRv4KRJJ3UNvjO2dXe6Sx5S6JWkO2KKST3610Em5UwFVwrEdjjGCU /bzsK10w9RyZ011ZgtJdqwQM8UkVMDdSorhWZHWlqWSegyuT7/F+Kvn/k5ZVCBaC7JOI 3n/4nvrW5OqAeS/duyTHRXaI0hcJwylG38t/DfRs3kA/9Z55Cp4xmg2lsAO9iiVzrn7l N+iPoVyAiy65SJQjVmXwBzv+OsN4fXPnZYwM9wakLUknrrHymGjsnHccPQc5l+U9/Z+a NR+g== X-Gm-Message-State: AOAM530i4rx0yMEeqA/KI0Rl61w7QLqt+Phn23jlCdtHt0oVBWk5QWR/ 9xDpvUyb5WA84dofJIBiz+xXPPDIXc7+wQ== X-Received: by 2002:a5d:83c4:: with SMTP id u4mr1473648ior.21.1624487043319; Wed, 23 Jun 2021 15:24:03 -0700 (PDT) Received: from [192.168.1.134] ([198.8.77.61]) by smtp.gmail.com with ESMTPSA id e4sm157435iov.33.2021.06.23.15.24.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jun 2021 15:24:02 -0700 (PDT) Subject: Re: [PATCH v2 2/2] io_uring: Create define to modify a SQPOLL parameter To: Pavel Begunkov , Olivier Langlois , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: <6a566122-c4b2-6594-cc94-c578988d3f80@kernel.dk> Date: Wed, 23 Jun 2021 16:24:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/23/21 4:14 PM, Pavel Begunkov wrote: > On 6/23/21 7:50 PM, Olivier Langlois wrote: >> The magic number used to cap the number of entries extracted from an >> io_uring instance SQ before moving to the other instances is an >> interesting parameter to experiment with. >> >> A define has been created to make it easy to change its value from a >> single location. > > It's better to send fixes separately from other improvements, > because the process a bit different for them, go into different > branches and so on. It's not a huge problem even if they go to different branches, for these I'd be more comfortable doing 5.14 anyway and that makes it even less of a concern. -- Jens Axboe