Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp77057pxj; Wed, 23 Jun 2021 16:09:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwl5hHsg0swCaENhYX3pqlEEotl3th1rKMHFce2LVOXNul61/zP5uvHquNQjq7MoMj/SFj4 X-Received: by 2002:a05:6402:354b:: with SMTP id f11mr2804829edd.387.1624489767255; Wed, 23 Jun 2021 16:09:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1624489767; cv=pass; d=google.com; s=arc-20160816; b=IHFxTq+TrP+HwBv/3uL0FXHVSVWp1TtdQ05W2Get2OH5S8nV75m6KXPnT+eHrcz5Mw tE5GlJCqu3g82drloJCugKUmllDemMeKiodBcwMuBudcetrNwcMdpkB1PAsPKft5MkEZ kIHnlphewkfoK67dLf+suNPilBzHULqMrKjpa6aJi+urwKEPBV43LmAlfdAj8BzLNjdv vYuaKvxbxvAdqroLbWTaAwDWKQ7U6N4A3SRUY/GMMkCU1aVvN8/VeoeYxtaEwvQ0UfwB aeEJNe+gzHMqvEvOfKFpcp3/0z0isImY0d5WtuzHx3OTCfUsg1P3Bve2iLGVTb9Vw9ON RNIg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=SItRF4AQvZE4S9Y4n3JHJl8Oo2HpyCmycPOs/yrugrs=; b=YLDGm3DaTdGSMbcjMzPKLYgtuN575LGFgf1LE+7DiGoOISlNPatzuOt01XM32QjXPr CARDxzNSl7xHpkgshi6UGtD8aF6WmZXEP/IH/pYVsTIU4LFzUpgSTg0NRTrQe6umy4Kb XIVTeBeqIO3eZPgeIxD+OctEV0OXXG/92EhmlvMOW3BNZGultgoYoy8+bKLvys2KrVWY gjA8TRW6JRD/bfn5797lJHJMaGjPAUnuERI2Fn1eQFrwfmAuvVvaq+Q5N16EyxS+pMUp SbIwXcC38zuqL/dh3GRwXKkFdtqmr7xWeOkfVJ+w4jXVOaTqVP5eB216Aze/pj19SE/r 5+ew== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@iki.fi header.s=meesny header.b=anaqdPfl; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a19si1092709edr.397.2021.06.23.16.09.03; Wed, 23 Jun 2021 16:09:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@iki.fi header.s=meesny header.b=anaqdPfl; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230014AbhFWXJK (ORCPT + 99 others); Wed, 23 Jun 2021 19:09:10 -0400 Received: from meesny.iki.fi ([195.140.195.201]:42508 "EHLO meesny.iki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230040AbhFWXJG (ORCPT ); Wed, 23 Jun 2021 19:09:06 -0400 Received: from hillosipuli.retiisi.eu (dsl-hkibng32-54fb5d-176.dhcp.inet.fi [84.251.93.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sailus) by meesny.iki.fi (Postfix) with ESMTPSA id E38132025E; Thu, 24 Jun 2021 02:06:45 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1624489606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SItRF4AQvZE4S9Y4n3JHJl8Oo2HpyCmycPOs/yrugrs=; b=anaqdPflwfAB39MH2ES/aWFjkeOFuTX43DP5OaB6qaA0wB22L2VKw3bs3BiYzzqwXdrhVo C+8dgXAZWWzKymPW3fi7RVqhvz+urVwQXSsWASNxRXyW+ujWnUFyP4pdwX4/JpeiCYA3gW qNq5zaj0a0VEYp7BezhNemi9EndefuE= Received: from valkosipuli.localdomain (valkosipuli.localdomain [IPv6:fd35:1bc8:1a6:d3d5::80:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.eu (Postfix) with ESMTPS id 3A6ED634C87; Thu, 24 Jun 2021 02:06:32 +0300 (EEST) Received: from localhost ([127.0.0.1] helo=valkosipuli.retiisi.eu) by valkosipuli.localdomain with esmtp (Exim 4.92) (envelope-from ) id 1lwBxF-0000zc-CY; Thu, 24 Jun 2021 02:06:45 +0300 Date: Thu, 24 Jun 2021 02:06:45 +0300 From: Sakari Ailus To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com, mchehab@kernel.org Subject: Re: [PATCH -next] media: omap3isp: add missing unlock on error in isp_subdev_notifier_complete() Message-ID: <20210623230645.GI3@valkosipuli.retiisi.eu> References: <20210512092301.4124736-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210512092301.4124736-1-yangyingliang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=sailus smtp.mailfrom=sakari.ailus@iki.fi ARC-Seal: i=1; s=meesny; d=iki.fi; t=1624489606; a=rsa-sha256; cv=none; b=kZR9CAlYl3f+UigA8iYtIK9ylAoTbnQVLj7OISDf+lSAqNmxgy0wshDeZRObZPoy4R9VyO 2K7+Camv032bOm7aGec5UHeXuferZE1hCKAiWPnErAOhrgprkOG5t4t9mUyeBkxerxCHLk mA+BTakhT2JciFSwGKl+T8ksfnlV2MQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1624489606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SItRF4AQvZE4S9Y4n3JHJl8Oo2HpyCmycPOs/yrugrs=; b=Li1xDqp/2H8nPQMIEkCG3V/by3l7u8rm4aw3aaNE2depkwaeEdZNZwDI4Zt+30ZcJuxkev LAPoKq8aEROuuRPGNnpSF/N0MtXBAz4uqvnuD/wKsXjgymF5tDIapQrD9wSwaKB/4AGIec nvTX4GlzI8zZC/bU09OS5CHoac1sW5w= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yang, On Wed, May 12, 2021 at 05:23:01PM +0800, Yang Yingliang wrote: > Add the missing unlock before return from isp_subdev_notifier_complete() > in the error handling case. > > Fixes: ba689d933361 ("media: omap3isp: Acquire graph mutex for graph traversal") > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang Thanks for the patch. This is already fixed by another patch, accidentally left sitting in my tree... It'll be in the next pull request. -- Sakari Ailus