Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp95641pxj; Wed, 23 Jun 2021 16:42:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwsevKKdfSpro7dmqjMRwnqtfqxT9hLIdeuYAVSo/yrVzPtwvBlOJqNp/mGFELrdu0w7lD X-Received: by 2002:a05:6402:35c8:: with SMTP id z8mr2980772edc.348.1624491719830; Wed, 23 Jun 2021 16:41:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624491719; cv=none; d=google.com; s=arc-20160816; b=PJ7IMR38LgZ7uAC3I71jr4QrHDtFvMeb9BMf2oaDgdyRFrFPGDeH08FjQIpmDe99xV x648eUalAktJfSlEasJLazUsOhoAQ/kfu2gFwnQt3kuYLC8PgiUHqenGtcVCUo+1T6Cl r78FyjwwCIdp93xj5EWL5+1XLPwTcZlP/n2K7ZkqiNQtHL/y0W1IxrULhw3CFo7M3KyO KOa0B+j0kmi42twh767cr/v6MIMvZLSvMYltDpdbtJ7PSxIAOHriPsoRSncLAeXSMPJn KkC7AnoQ9Hk8YSQoXhiTMbapdY3viv+F6gpIAwZ/Le0wvBV6MTQinwfpx43INnhs87uB 1hiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:subject:from :references:to:dkim-signature; bh=dIcMIKiqgju7ISXHt5Sf7jt9PfPhvTF5fdN3Qy2UJsU=; b=IngAqqYHQBtaEkPXvXjblLukZCOfgDsPdKg8evYx+njIltkMZ2Kn4RsASU0ruKMwS4 PM628nizQnTDyuv2gfvm2k7ATnFch6wt1E7dNlHoBHd8pIMnaXXPoz/G0WwY/d9KpbZr Z+X1tDRcgG86AC0lD4nwECgIYl6eVUT/EBaHSXIF9xxduUdDbIiPWSEF10rNGmya6wTb 8N2W4Ic4/c2c45GMAFZgAwF8TF9e57VLMbeRmlnFDotrJ6RO3rIxTbKtSS7oAv7HEZyA ldEcDOvzdlVPcQn9lZtlbHyGpu33SjZ5FJgv4YsJWkrVIfuMqIpePF3pFN7EneX2B6/c RkKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Bscv8COq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m8si1183565edc.424.2021.06.23.16.41.37; Wed, 23 Jun 2021 16:41:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Bscv8COq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229822AbhFWXmW (ORCPT + 99 others); Wed, 23 Jun 2021 19:42:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229826AbhFWXmV (ORCPT ); Wed, 23 Jun 2021 19:42:21 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED6C9C061574; Wed, 23 Jun 2021 16:40:01 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id o22so1757577wms.0; Wed, 23 Jun 2021 16:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:references:from:subject:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=dIcMIKiqgju7ISXHt5Sf7jt9PfPhvTF5fdN3Qy2UJsU=; b=Bscv8COquz6oOXtYPkM82AFLwQ4HLPDrGR15Ksn5WmHl67ROgBeViE/NpaBnXPAy7L LL/6lC2SZFXvL+50PpWWzo35GqzWDuJg2KSy/gPOcPNAb7b7yX0HHVWUjw4pLscGYzJV pj06iRfaPLjMx0olGsvLwloIUXinqinKA5OhE3u01/voB2byrKGvcMIzsB1Q8i7r6BEM j7g5OtXNXhknSkUscwJkpdYyAaKMhtmBBHUfxl/DFz+i8PtRQKQ9a2iBenFGFI1em4gX SZmLwrdkhbsRmqKY93Sq+q67th8MMUSK3iGxAsDomJlZ6hfUM3oYBv8f3/+3cE1ntxgb ghWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dIcMIKiqgju7ISXHt5Sf7jt9PfPhvTF5fdN3Qy2UJsU=; b=jbjoWAMYpzSodKYf29D89O1Zz6wsndtVBfpcrLNmQWzQyYhO0sNm30CG9p4dE0KOHQ Nzsfs1iiJBk1uyiBSarG8Xxc4gS4LMBqlV3/HozYCi7mOXUhbqRbzKlVffhd9/eRJHn5 186CQaK8c+WFNnEzCIsGFAvgTQXs5IoB7DY2SZ6vafaHieUmmwNFbHq3UTm9wjrz/9o4 Bk2fqHWfQjU9kJlxYYCDTeESqslY3wUt0eDHQJN1Qp+f1GZ9M4RhzHL8VDf26NKSD6eE ii9vpPcvqtU6W9lMMBQ4n/6xKdL+BAV4J8C27jrUn11Ko6kEr0z+XVXywJytyelaC7z1 GoGw== X-Gm-Message-State: AOAM530/oczfoMiLBAvgIKfr0KAJvC9dzdqD4sQpr3ZnXsHdgKICfnGC yfGe4Cru17ZE2OZi7HxZ/g96Ajv0A5TVV/hu X-Received: by 2002:a7b:cc92:: with SMTP id p18mr681984wma.93.1624491600385; Wed, 23 Jun 2021 16:40:00 -0700 (PDT) Received: from [192.168.8.197] ([148.252.132.93]) by smtp.gmail.com with ESMTPSA id y66sm1159957wmy.39.2021.06.23.16.39.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jun 2021 16:39:59 -0700 (PDT) To: Jens Axboe , Olivier Langlois , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <6a566122-c4b2-6594-cc94-c578988d3f80@kernel.dk> From: Pavel Begunkov Subject: Re: [PATCH v2 2/2] io_uring: Create define to modify a SQPOLL parameter Message-ID: <8f4c6fad-ff01-4b3a-a0d8-06717af5095c@gmail.com> Date: Thu, 24 Jun 2021 00:39:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <6a566122-c4b2-6594-cc94-c578988d3f80@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/23/21 11:24 PM, Jens Axboe wrote: > On 6/23/21 4:14 PM, Pavel Begunkov wrote: >> On 6/23/21 7:50 PM, Olivier Langlois wrote: >>> The magic number used to cap the number of entries extracted from an >>> io_uring instance SQ before moving to the other instances is an >>> interesting parameter to experiment with. >>> >>> A define has been created to make it easy to change its value from a >>> single location. >> >> It's better to send fixes separately from other improvements, >> because the process a bit different for them, go into different >> branches and so on. > > It's not a huge problem even if they go to different branches, > for these I'd be more comfortable doing 5.14 anyway and that > makes it even less of a concern. Ok, good to know. I was finding splitting more convenient as a default option, easier with b4, more confidence that they apply to the right branch and so on -- Pavel Begunkov