Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>
CC:     "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: RE: [PATCH RFC] usb: renesas_usbhs: fifo: : use proper DMAENGINE API
 for termination
Thread-Topic: [PATCH RFC] usb: renesas_usbhs: fifo: : use proper DMAENGINE API
 for termination
Thread-Index: AQHXaBb4DCoFDFqLl0Gk0IEvbdRVSKsiXRSg
Date:   Thu, 24 Jun 2021 01:27:09 +0000
Message-ID: <TY2PR01MB3692C7B6E0FD027B5C3E05B5D8079@TY2PR01MB3692.jpnprd01.prod.outlook.com>
References: <20210623100304.3697-1-wsa+renesas@sang-engineering.com>
In-Reply-To: <20210623100304.3697-1-wsa+renesas@sang-engineering.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?r8TxsTdiiUNvrVWqK96u1IT8M2fjhRkVA4Pz4HD5naQ2mUYxdCzA4v57kLnr?=
 =?us-ascii?Q?bm8RakLA6iU4lnpJylugOUse2EybY2I2ZKRarUhR/SM0PHkIf0wCRYz9OdVY?=
 =?us-ascii?Q?+DcQeFEYJz3qyvEVMvidYA+D7gBjaCe3hncnteyDfE0TpOCTTD1WqOFsIQI3?=
 =?us-ascii?Q?eRS5KBlw7rQZjTxfxSynvNLcs48rNuVlJdralTp0LQHoPj/pyIE9mZgRV5no?=
 =?us-ascii?Q?2MUlw955sj2gdo9GtAggdFvlZbZik5xy10/hUPeqWQmxg2s3591MM73dY58r?=
 =?us-ascii?Q?EbhsRgv9vh2P1rIDcbea78LJGjmbDnWH3JlqEP+BTs4t2YF9i5uszUTfK+vj?=
 =?us-ascii?Q?KTuVXdiCIG5PRGaYKdyc6pDBM1kvYV3amNIYTA8B3y7XJbcCIeIFhLFx0nOe?=
 =?us-ascii?Q?qlrU7lNe7uTEYoacWzXUx3WLEua1vSNL+rx09ZiYW/WvwG7hRvnMKp3YSZKD?=
 =?us-ascii?Q?ZDdURC9rM/BUTbUzbCo/HhxdBIJ9/wgKGEFyY8ITQArX6hyuSRPfhjTnn0CZ?=
 =?us-ascii?Q?W7StuNNIRcMB+MQ2oDn0tegpDAtQWSc0rZd2F/9RNtw4aPu9ohuRoil7FSsW?=
 =?us-ascii?Q?qtnEda3q5YkEgbHxb9meDnATx2b81mDsZdv+1Mdis1UcmJv6prTG5ikbhhBl?=
 =?us-ascii?Q?h3JCBRqAvCHxNQKGcvgkqwsB1LPFXUrp2/kPr9bJQrO0Ia1jdkcrnmvcM4L/?=
 =?us-ascii?Q?OLNSAKYeodqrgbzVe4LIbfpH165TINlfF4YBJimRKOmSpVQnbD61LdzXngA3?=
 =?us-ascii?Q?V4drJ4fCTYjWYnTkh5iEbGjMwMi3THzzQaw1hlMfAIUWIEZZIsuKsxeEjyS2?=
 =?us-ascii?Q?VHLR+bwCYjq6ZF2f0Mv9Nv5wi0WNyxqiqgCE9s7ZPhReb+lECnpxDJ5xOY+N?=
 =?us-ascii?Q?+RHHy9gZTXi8LlgUxhcUDOVmGmBYEPomtO8Gj85OLiXAOdvBDssuwqkT6Pj3?=
 =?us-ascii?Q?bZVWcHfuq7vEiadTDRV3OEoCgYWuVFcOb3DnAauSZheEX9QYbKDnvMATG4ih?=
 =?us-ascii?Q?BlYqu5s4R+TyvX9SjRp2XizYJwNYIRK4t41b5sfP4XtJbqWNVeeSgGQD3jjv?=
 =?us-ascii?Q?G/JJCPdpkPuxyaKPH5kFrPpALJPkWq5KvQyWAamqTKxYOuwZuz3VDITUtFpj?=
 =?us-ascii?Q?Arfm+7FzZR+i3eBOjeUX9Pj0evNj3/daHLG9uJTpo/T3rE90WEd9nEaTExUh?=
 =?us-ascii?Q?nhsqSm50lH1D8LOrfGvjWW+lhkyrfKqSiS7P4aznNiBtwKYTKc/u7apcct9M?=
 =?us-ascii?Q?NRnKJ028U883RIwtoqsxI6lXyW+Bh+fmpPWs6yJIBLtFH/D3paDR5u0vgq9Q?=
 =?us-ascii?Q?qWWcUCBn88+6PsKLTf/iQ2tw?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB3692.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f1280ac-d5ef-4260-02ba-08d936af2fd0
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2021 01:27:09.8194
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oBQCb/RoqUF/N5Mp6ymnTGEQ5CCDvxxvGAwgcwva01+pZu8TKsf6JWuP4n7hn1oMaWh20pQmL7Z4UdAit3sW0B+y/akSG0DhJ1qlqXGi6ZXAev7DgFOMx9R8qaMCEztS
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB5918
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Wolfram-san,

> From: Wolfram Sang, Sent: Wednesday, June 23, 2021 7:03 PM
>=20
> dmaengine_terminate_all() is deprecated in favor of explicitly saying if
> it should be sync or async. Here, we want dmaengine_terminate_sync()
> because there is no other synchronization code in the driver to handle
> an async case.
>=20
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>=20
> Shimoda-san, can you please double check if this works with the
> additional locking in this function? Thank you!

Thank you for the patch! I checked and tested this patch and worked
correctly on my environment.
# To be honest, both shdma and usb-dmac driver doesn't support .device_sync=
hronize
# so that _async() is enough for now.

However, I have a concern which this patch will conflict my fixed patch [1]=
.

[1]
https://lore.kernel.org/linux-renesas-soc/20210611105411.543008-2-yoshihiro=
.shimoda.uh@renesas.com/

Since I caused a trouble [2], the patch [1] was not merged yet.
So, I intended to resend the patch in near the future.

[2]
https://lore.kernel.org/linux-renesas-soc/TY2PR01MB3692555C6EAC8F02BC8B3D63=
D8329@TY2PR01MB3692.jpnprd01.prod.outlook.com/

In backporting point of view, I guess it's better to apply my fixed patch a=
t first,
and then apply this DMAENGINE patch. But, what do you think?

Best regards,
Yoshihiro Shimoda

>  drivers/usb/renesas_usbhs/fifo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs=
/fifo.c
> index b5e7991dc7d9..6176f2325f03 100644
> --- a/drivers/usb/renesas_usbhs/fifo.c
> +++ b/drivers/usb/renesas_usbhs/fifo.c
> @@ -121,7 +121,7 @@ struct usbhs_pkt *usbhs_pkt_pop(struct usbhs_pipe *pi=
pe, struct usbhs_pkt *pkt)
>  		if (fifo)
>  			chan =3D usbhsf_dma_chan_get(fifo, pkt);
>  		if (chan) {
> -			dmaengine_terminate_all(chan);
> +			dmaengine_terminate_sync(chan);
>  			usbhsf_dma_unmap(pkt);
>  		}
> --
> 2.30.2