Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: /c09j9racwkajhn+fYOwHiYcU4gpl8BFRzHewQWByqS1HikOPNNxm1C8g2nlAnveec6qJxpMYs
 ctCEOQsn55xg==
IronPort-SDR: xtb9n9qEL3B0fL6bYOm7ZIMzNjHxBFRLJbmWtIhVhK0xo4O+EIGm1id8xJIFD+V9MYWUATH02j
 kPcytLF1LlJA==
Date:   Thu, 24 Jun 2021 10:56:07 +0800
From:   Wong Vee Khee <vee.khee.wong@linux.intel.com>
To:     Marek Behun <marek.behun@nic.cz>
Cc:     Ling Pei Lee <pei.lee.ling@intel.com>,
        Russell King <linux@armlinux.org.uk>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>, davem@davemloft.net,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, weifeng.voon@intel.com,
        vee.khee.wong@intel.com
Subject: Re: [PATCH net-next] net: phy: marvell10g: enable WoL for mv2110
Message-ID: <20210624025607.GA21875@linux.intel.com>
References: <20210623130929.805559-1-pei.lee.ling@intel.com>
 <20210623233854.03ed9240@thinkpad>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210623233854.03ed9240@thinkpad>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

Hi Marek,

On Wed, Jun 23, 2021 at 11:38:54PM +0200, Marek Behun wrote:
> On Wed, 23 Jun 2021 21:09:29 +0800
> Ling Pei Lee <pei.lee.ling@intel.com> wrote:
> 
> > +		/* Enable the WOL interrupt */
> > +		ret = phy_set_bits_mmd(phydev, MDIO_MMD_VEND2,
> > +				       MV_V2_PORT_INTR_MASK,
> > +				       MV_V2_WOL_INTR_EN);
> > +
> > +		if (ret < 0)
> > +			return ret;
> 
> Hi, in addition to what Russell said, please remove the extra newline
> between function call and return value check, i.e. instead of
>   ret = phy_xyz(...);
> 
>   if (ret)
>      return ret;
> 
>   ret = phy_xyz(...);
> 
>   if (ret)
>      return ret;
> 
> do
>   ret = phy_xyz(...);
>   if (ret)
>      return ret;
> 
>   ret = phy_xyz(...);
>   if (ret)
>      return ret;
> 
> This is how this driver does this everywhere else.
> 
> Do you have a device that uses this WoL feature?
>

Yes. We have Intel Elkhart Lake platform with Integrated Sypnosys MAC
controller(STMMAC) paired with External PHY device (in this case the
Marvell Alaska 88E2110).

BR,
 VK