Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: Re: [PATCH v38 1/4] scsi: ufs: Introduce HPB feature
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Bart Van Assche <bvanassche@acm.org>,
        Daejun Park <daejun7.park@samsung.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "huobean@gmail.com" <huobean@gmail.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        JinHwan Park <jh.i.park@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        Dukhyun Kwon <d_hyun.kwon@samsung.com>,
        Keoseong Park <keosung.park@samsung.com>,
        Jaemyung Lee <jaemyung.lee@samsung.com>,
        Jieon Seol <jieon.seol@samsung.com>
In-Reply-To: <5a71d4c3-2f1f-3c85-eb90-381775e7030e@acm.org>
Message-ID: <20210624064044epcms2p3dc2e0fcb8c8e61e6899b5cf6876b2103@epcms2p3>
Date:   Thu, 24 Jun 2021 15:40:44 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <5a71d4c3-2f1f-3c85-eb90-381775e7030e@acm.org>
        <20210616070700epcms2p734db9b60e13229696fb3cda5f69e210f@epcms2p7>
        <20210616070812epcms2p4650ce5cd78056dce9162482e59bb74dd@epcms2p4>
        <CGME20210616070700epcms2p734db9b60e13229696fb3cda5f69e210f@epcms2p3>
Precedence: bulk

Hi Bart,

> On 6/16/21 12:08 AM, Daejun Park wrote:
> > +What:                /sys/class/scsi_device/*/device/unit_descriptor/hpb_pinned_region_start_offset
> > +Date:                June 2021
> > +Contact:        Daejun Park <daejun7.park@samsung.com>
> > +Description:        This entry shows the start offset of HPB pinned region.
> > +
> > +                The file is read only.
> > +
> > +What:                /June/class/scsi_device/*/device/unit_descriptor/hpb_number_pinned_regions
> > +Date:                March 2021
>  
> Please change /June into /sys and "March 2021" into "June 2021".

OK.

>  
> > @@ -7094,6 +7119,7 @@ static int ufshcd_host_reset_and_restore(struct ufs_hba *hba)
> >  {
> >          int err;
> >  
> > +        ufshpb_reset_host(hba);
> >          /*
> >           * Stop the host controller and complete the requests
> >           * cleared by h/w
>  
> Shouldn't the ufshpb_reset_host() call occur under the comment instead
> of above?

OK, I will.

Thanks,
Daejun

> Thanks,
>  
> Bart.
>  
>  
>