Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp371291pxj; Thu, 24 Jun 2021 00:53:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwiOoooHu/ncrMNhQJ9PFyg/LXpd8y5dhY0lNIUa2Qo8hiLCU/ANFvaqpYd9q3Hqnm/jEuR X-Received: by 2002:a17:906:17c4:: with SMTP id u4mr4064543eje.481.1624521202665; Thu, 24 Jun 2021 00:53:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624521202; cv=none; d=google.com; s=arc-20160816; b=tRLiIisSwr33cFAuM7eWabwT8txjebAbQ2Bb1YjA/gB0aNgnJ8HKYX8SIv5hNT7oww aM6CFM0hOj9TwKpl3yaaJfih4WJk3NRLFuBU3FLv7pPyAk3nJfEenUuS6YxPSpO0dYOb 8I9vjVpUj4Pu6DmEbRb4nY1aJ+Ns7Ec7jfzzw+05VV7GUfWv7qxKOcNOZ1KrhXJBvR1x taFa96WUolnL/fSnepHa9fNxdmAdL3El6245AnfqrMuowm/j6HbYk/WEnznOlwLtM6Xo GcwVuWa/jGyqfnUf/JuC6uIYxKK8BTp4uNdVEApsALchx8Ia1j3llwd2fqVJvnpDkMtb IlXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=oqBoh022fhxEJCIZzXb5t3KHzbhFEYi4IhyBKteBSZw=; b=MpFNKi4xK95Cbkt2Tc0EIg8aDqeDehHE99PsjOSCh9FepO2965S3iH/wsdfWf//EAj A4B+tYiIdJFV64cUOt67eVRtDGzZarQ/g/2RduTTCF6BnqDoCsfjWYN4JMuF/hqC2wnl I+zIIwmSYTIAP4HJP2BKPhNrSYZzn6pmKtd8K4RAipzXDq1bBvdHg7Av+VxlLDpO5vL5 aCz8YgkkXjAJBor/FoA64b9wlAzYChKKXJBItkwTfXpfjFnL6mUWTlWgyrmqgDtUGLd7 WxuRR/0xli1wmZLCBzgdOyv+IvJQZ+JmRcV5eyXXmctDv++C9egWX2Y3moG4E/xh02kF jlYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w3si2373001edd.79.2021.06.24.00.52.59; Thu, 24 Jun 2021 00:53:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231803AbhFXHy0 (ORCPT + 99 others); Thu, 24 Jun 2021 03:54:26 -0400 Received: from cmccmta3.chinamobile.com ([221.176.66.81]:25699 "EHLO cmccmta3.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231709AbhFXHyZ (ORCPT ); Thu, 24 Jun 2021 03:54:25 -0400 X-Greylist: delayed 572 seconds by postgrey-1.27 at vger.kernel.org; Thu, 24 Jun 2021 03:54:25 EDT Received: from spf.mail.chinamobile.com (unknown[172.16.121.7]) by rmmx-syy-dmz-app10-12010 (RichMail) with SMTP id 2eea60d43758048-ec932; Thu, 24 Jun 2021 15:42:17 +0800 (CST) X-RM-TRANSID: 2eea60d43758048-ec932 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[223.112.105.130]) by rmsmtp-syy-appsvr04-12004 (RichMail) with SMTP id 2ee460d43752bc5-e26d2; Thu, 24 Jun 2021 15:42:16 +0800 (CST) X-RM-TRANSID: 2ee460d43752bc5-e26d2 From: Tang Bin To: linux@armlinux.org.uk Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tang Bin Subject: [PATCH] ARM: bL_switcher: use IS_ERR_OR_NULL() to simplify code Date: Thu, 24 Jun 2021 15:42:23 +0800 Message-Id: <20210624074223.11372-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use IS_ERR_OR_NULL() instead of IS_ERR() to simplify code. Signed-off-by: Tang Bin --- arch/arm/common/bL_switcher.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/arch/arm/common/bL_switcher.c b/arch/arm/common/bL_switcher.c index 9a9aa5354..b8e8e2567 100644 --- a/arch/arm/common/bL_switcher.c +++ b/arch/arm/common/bL_switcher.c @@ -352,11 +352,9 @@ int bL_switch_request_cb(unsigned int cpu, unsigned int new_cluster_id, t = &bL_threads[cpu]; - if (IS_ERR(t->task)) - return PTR_ERR(t->task); - if (!t->task) - return -ESRCH; - + if (IS_ERR_OR_NULL(t->task)) + return t->task ? PTR_ERR(t->task) : -ESRCH; + spin_lock(&t->lock); if (t->completer) { spin_unlock(&t->lock); -- 2.20.1.windows.1