Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp23823pxv; Thu, 24 Jun 2021 01:46:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzIbrJ2iTTUTvpRcBeU3HDcCin6W6Fa8rgyto15FKikPDDWMsxE9WGS/0bLUDMZDdHG4EP+ X-Received: by 2002:a05:6402:90a:: with SMTP id g10mr5502400edz.365.1624524380902; Thu, 24 Jun 2021 01:46:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624524380; cv=none; d=google.com; s=arc-20160816; b=wiJVQQMFGtVbPRJa3nklOBwwS1Lo73wL3nrzCVwv6zs6u8HgkeuUZEMKArbBZka6SU S99dTWN7Qgv5M9WFXQ0uQHJaNO+QlZ3ZkXELQdwREoKfKysg7laJyELcwFk6xLwLAl2G qTkWh3AI+yjIiN+BHbQY/4fIsp+9pBu3PMsp2yx6l0gCr1HvapkJ0P+gBOeThKixPEwd mvNuXtKzprgAI18OQnQMy7m+elA8P1BWisuBxuH1Q9MhwBm7Z5l/ITy23PDXPr6uY9cz lvCazfcFulO2mDeHfZqeaLT4TMuo6r1hhBL0RXxu33sPmGh60UFggr2CPnGRT1MCKCM/ BvEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:message-id :mime-version:in-reply-to:references:cc:to:subject:from:date :dkim-signature; bh=yhvFMq52QAZ9Grg2JNZMftQHgs3RA/23cRzSXZS17k0=; b=J5v7LZCPy+/IR2JNbo/+Hl5bI7YYy/+Ymin9G7zgVrcXp+is5loqtFFQF+92YXIfe1 a+YIPuEonrBDH7bZmNNgYddat5C/O0yrjdlY8ID2CppbLT/n10OiV8Rk0t6LfI6qITRE lGtl8Hhq0py23HaCqoDn8EzSB2p33Mx92/FdeiAKULJ5+FSUXaeR053slQsc2YvFOEYo O9e+A2AyIwzS563oig67aOO18yaULnQETRboP/294i51F/2xrLx5uMcXFSsRzyfrw6pZ axdHDZ00DlwRCmdYEsJU/qIG8aH1AF6ag5474kznoZlBMugayZ6IYRoTGO5/vtu5n3/U kBAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gAOPVlMk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d3si2294555ejl.143.2021.06.24.01.45.55; Thu, 24 Jun 2021 01:46:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gAOPVlMk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229950AbhFXIp1 (ORCPT + 99 others); Thu, 24 Jun 2021 04:45:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229890AbhFXIp0 (ORCPT ); Thu, 24 Jun 2021 04:45:26 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFD76C061574; Thu, 24 Jun 2021 01:43:06 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id u2so2596436plf.3; Thu, 24 Jun 2021 01:43:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=yhvFMq52QAZ9Grg2JNZMftQHgs3RA/23cRzSXZS17k0=; b=gAOPVlMk/C7twisLQPwKCNWWewikvdh3rxAsE3ZtniqnTTajI/NMXYxiFGdNgFsAb5 HygkoSZIJ35Gv0csn5ROrHrh88J/UJu+eQftLB0ieYLqxUsTshCjLCXS6gCtoawRaivr 09ywa3Xbj5hpxhL9dwXklJBlZskMpYTiquDzecxyLb9cNgD5q6A07FqSvRwXDFm8rCjX BNwM+/+ntQwzLzmsj9QUq7rwCh6LY1EpIQpDwzEMVK8zxcfbTYEjGD1dfARZQBO2ATzQ bXhbvn6/C4gpLxmOLhsNYYF/nPrsfEvzkHwVbcZduLr1uAs8pjNAgfhm1dhPRaqpCZmK qi+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=yhvFMq52QAZ9Grg2JNZMftQHgs3RA/23cRzSXZS17k0=; b=BU3nHJhNpbqzNyn2Kk9HrmtaroFtkm9XNqK5e5rbR+Z/NMmGxaFRQCbSavR9e0lgxi Fto6wNZ7gHIXsYpSxP7JsWapZEHQ7HstMj4Mok7pyhxT6U0JvAV4VjCJ8v1RPRUoUtaa QdA0PE126I/bgM2S3EOjE2wcFy9mVGyhCrymp5kPkN8rGn6AhtPYFFQUtDBce5xyhlpA HfRQsknWKQWdXZYWvm7l7SzIADJtcUP+wr4aZYOzjWrbBw2lg898vMPB+7nLlVOlc8hX yS4kaHsTLtjhHRdHBz5UNjEAlDm3mHWI41vcsDCosfydV+awa5iNsebEytBkmAfEvrQ7 R4Lw== X-Gm-Message-State: AOAM530FY2fKReHTCME6EoyzKwO3TJNySRwRM0XlkEd8kn6DDgZAo7Bc jhQpyZRVnO8q12Jf13WlELw= X-Received: by 2002:a17:90b:793:: with SMTP id l19mr14007232pjz.111.1624524186360; Thu, 24 Jun 2021 01:43:06 -0700 (PDT) Received: from localhost (60-242-147-73.tpgi.com.au. [60.242.147.73]) by smtp.gmail.com with ESMTPSA id 23sm1841779pjw.28.2021.06.24.01.43.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 01:43:06 -0700 (PDT) Date: Thu, 24 Jun 2021 18:43:00 +1000 From: Nicholas Piggin Subject: Re: [PATCH 1/6] KVM: x86/mmu: release audited pfns To: Aleksandar Markovic , Huacai Chen , Marc Zyngier , Paul Mackerras , Paolo Bonzini , David Stevens , Zhenyu Wang , Zhi Wang Cc: Alexandru Elisei , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, James Morse , Jim Mattson , Joerg Roedel , kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Sean Christopherson , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Will Deacon References: <20210624035749.4054934-1-stevensd@google.com> <20210624035749.4054934-2-stevensd@google.com> In-Reply-To: <20210624035749.4054934-2-stevensd@google.com> MIME-Version: 1.0 Message-Id: <1624524156.04etgk7zmz.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Excerpts from David Stevens's message of June 24, 2021 1:57 pm: > From: David Stevens Changelog? This looks like a bug, should it have a Fixes: tag? Thanks, Nick >=20 > Signed-off-by: David Stevens > --- > arch/x86/kvm/mmu/mmu_audit.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/arch/x86/kvm/mmu/mmu_audit.c b/arch/x86/kvm/mmu/mmu_audit.c > index cedc17b2f60e..97ff184084b4 100644 > --- a/arch/x86/kvm/mmu/mmu_audit.c > +++ b/arch/x86/kvm/mmu/mmu_audit.c > @@ -121,6 +121,8 @@ static void audit_mappings(struct kvm_vcpu *vcpu, u64= *sptep, int level) > audit_printk(vcpu->kvm, "levels %d pfn %llx hpa %llx " > "ent %llxn", vcpu->arch.mmu->root_level, pfn, > hpa, *sptep); > + > + kvm_release_pfn_clean(pfn); > } > =20 > static void inspect_spte_has_rmap(struct kvm *kvm, u64 *sptep) > --=20 > 2.32.0.93.g670b81a890-goog >=20 >=20