Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp63383pxv; Thu, 24 Jun 2021 02:54:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7YoKYqi7GADy/WwcPgYZ9XWftkpGce+r6FTAOYywnPB9rnmgGMHC03ST521QJt32J65c5 X-Received: by 2002:a05:6638:3896:: with SMTP id b22mr3869388jav.37.1624528484372; Thu, 24 Jun 2021 02:54:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624528484; cv=none; d=google.com; s=arc-20160816; b=GQaEpcZEbOXmr7Wl5vG5DvXSjNrpQw6nrC1LKhNGLTiJX8s2Kk2Dh3x9ebZ77U8+fT k/lQi6SuBSTcXRQXjaj8M2lxIAOYoUBL6XpGbssoWwIvcPJX877GkcqcmL/BETXszQq0 BcT8ZWkxDxXHynxRvA6oaiPpcWhv9TeMUnoFBhiv1tsT5iqRgUPyy2JMsaO8o4jJk0Gz /Ijj5lu0i5eAP3fAviJVg735T8eBEQ2JZhWtDyNvvdcKPJ4VmIGfFlGl1ZM1CqIjtxx8 MbpgcIbBIsBAS8I95kl0Bs8LSvQPDLOBdvr2Y2lmy6tbtl+JiRvJ4CGdDXSxn8EBSlUu VYXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=D6rgto8QOwuzbuG3+IcLd2Dpya5XNWPjc+F0E2n2abk=; b=e5/4Xt5ARGhSz+6cNQZRdSPTfBAeuZClb23y5YZ5/6bhAvSkGBbgXVHevTd9zqd665 9nC3d7Y5/ZgCoQtokZC7xdJ77rLhQ0CSRTMxOqYvJSv6dPO4RtpYJFZDH+PqMhAyMl9a adUj1uk3qhwTT8Ps942ZPlOQRCLz7xdpG7lJ8r+cwtHi6LMbAHJczx/yU23n2MStkP5Z gvZsnAbjoY5jGLU8Lcl/ybKFCV2HD/CjeDSSJXMiY0cY7hw1iccrInOHEW1FnD1dGNfb vD1HQUDL23McqZ1jRACcgCDkplSONDLvg0sJPWCDjorvDLEC3Q/PrFWhGMn/2jfPQkM7 Gaig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=W8lp65Pw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z11si3542199jat.113.2021.06.24.02.54.32; Thu, 24 Jun 2021 02:54:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=W8lp65Pw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231974AbhFXJ4S (ORCPT + 99 others); Thu, 24 Jun 2021 05:56:18 -0400 Received: from m12-15.163.com ([220.181.12.15]:57524 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229974AbhFXJ4Q (ORCPT ); Thu, 24 Jun 2021 05:56:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=D6rgt o8QOwuzbuG3+IcLd2Dpya5XNWPjc+F0E2n2abk=; b=W8lp65PwdW6zFcfV6KUeA Tnaqd6lGWEdfRyjzN7FkbaSv7I8FijDeHP/MelCNK5XuSjNCR3ucHpHjNuEseIku DilAPU9IUB05XgQ0ts6YEsIWD6BCpOK/VaSJXF30maXaiYd8vh9oVc/rm0ecTxki zeBA3QVRnCfXITmaDxzCLQ= Received: from ubuntu.localdomain (unknown [218.17.89.92]) by smtp11 (Coremail) with SMTP id D8CowADnVs+NVdRgzs9MAQ--.96S2; Thu, 24 Jun 2021 17:53:25 +0800 (CST) From: 13145886936@163.com To: linux@armlinux.org.uk Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gushengxian Subject: [PATCH] ARM: pxa: ssp: remove unnecessary print function dev_err() Date: Thu, 24 Jun 2021 02:51:06 -0700 Message-Id: <20210624095106.392317-1-13145886936@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: D8CowADnVs+NVdRgzs9MAQ--.96S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrZFWUCF45ur4kXFWUKr45Jrb_yoW3WFc_Ca 1Ika4kG3yrAr1vva4UJw1ayryaq3ZI9rWqkr1DKF1xKrW5Aa18G34DWFs7JF9rWw4I93y3 Xa93u3y3Cr1akjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU5dR67UUUUU== X-Originating-IP: [218.17.89.92] X-CM-SenderInfo: 5zrdx5xxdq6xppld0qqrwthudrp/1tbiXBe7g1Xl0Ei+8QABsV Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: gushengxian The print function dev_err() is redundant because platform_get_irq() already prints an error. Signed-off-by: gushengxian --- arch/arm/plat-pxa/ssp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c index 563440315acd..9e77b3392c1e 100644 --- a/arch/arm/plat-pxa/ssp.c +++ b/arch/arm/plat-pxa/ssp.c @@ -146,10 +146,8 @@ static int pxa_ssp_probe(struct platform_device *pdev) } ssp->irq = platform_get_irq(pdev, 0); - if (ssp->irq < 0) { - dev_err(dev, "no IRQ resource defined\n"); + if (ssp->irq < 0) return -ENODEV; - } if (dev->of_node) { const struct of_device_id *id = -- 2.25.1