Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: JnBDOllJaagMqwjMcFCU/i8apQ/2ApxHTzGvUkCrZfdyHUqq0MXxTP3jE5GICZrt+omVti7vpo
 /Efg5b4MoDZg==
IronPort-SDR: hxGimYrNOVFnAVYS5aiFz35SY4Vcr2F1fYWKInQ+WQsKeQggLJyhs3w26bYdmF8uj7sWDSwPrI
 DHGfY4IsWbwQ==
From:   "Voon, Weifeng" <weifeng.voon@intel.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     "Ling, Pei Lee" <pei.lee.ling@intel.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        "Jose Abreu" <joabreu@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "Ong, Boon Leong" <boon.leong.ong@intel.com>,
        Wong Vee Khee <vee.khee.wong@linux.intel.com>,
        "Wong, Vee Khee" <vee.khee.wong@intel.com>,
        "Tan, Tee Min" <tee.min.tan@intel.com>,
        "Sit, Michael Wei Hong" <michael.wei.hong.sit@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next V1 3/4] net: stmmac: Reconfigure the PHY WOL
 settings in stmmac_resume()
Thread-Topic: [PATCH net-next V1 3/4] net: stmmac: Reconfigure the PHY WOL
 settings in stmmac_resume()
Thread-Index: AQHXZoJFBtZ0uXgSn0S7qboFjm+Joqseb0UAgALh+bCAAK/dgIAA5rbA
Date:   Thu, 24 Jun 2021 10:07:44 +0000
Message-ID: <CH0PR11MB538084AFEA548F4B453C624F88079@CH0PR11MB5380.namprd11.prod.outlook.com>
References: <20210621094536.387442-1-pei.lee.ling@intel.com>
 <20210621094536.387442-4-pei.lee.ling@intel.com> <YNCOqGCDgSOy/yTP@lunn.ch>
 <CH0PR11MB53806E2DC74B2B9BE8F84D7088089@CH0PR11MB5380.namprd11.prod.outlook.com>
 <YNONPZAfmdyBMoL5@lunn.ch>
In-Reply-To: <YNONPZAfmdyBMoL5@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3XVR+j8EspbckidKEfzrArgZKzgk0xj/FVvclqYDPJ8sPfFMbcFQ69rTMOqC?=
 =?us-ascii?Q?zCgMjteO5bPmk1bNhNAABaHDp8xC2Ho4zVmn8hM5S0do413FHUbrZmcQ7ESy?=
 =?us-ascii?Q?XLaKHoB/xoC+NeF0pQv7RQ/2lPDXPL2Zb90MOVkMR0pFIplWC3BQ01B6UtUk?=
 =?us-ascii?Q?4tJLUQA17i3rX1txYe2fxTVr46mOvae69ZGCZRhXrV/FJP35g9/qd6rgYofJ?=
 =?us-ascii?Q?w4vE9/qVRnjMxD8HTiI0UMhxqXxh8aZ8IEUGlX6WXpwUEo8Yz96Q/QxMuyRF?=
 =?us-ascii?Q?2D08H/xiLHp55xvpuClTeBjHZjDO1LCWCQf9PJbXgCNKD931Pdgcm5wT88um?=
 =?us-ascii?Q?yoEjHmI8eWNW4QuIfc0W51VKtpVmL1NHGD/354Geh//eIyHwwjvf77/Ugbje?=
 =?us-ascii?Q?sJ4u4Th7m8dimgcSK1vp3sSpZ8illQNolzUf/78etXjPRp/5jE7QwsWQvAx2?=
 =?us-ascii?Q?q/zlPDgVGdzXlRSujvYWoLWuyWX3E9E9dG7cbvdeczdhqVnHZLsEOOov1oR3?=
 =?us-ascii?Q?WpLAhBoiu8Dm67bqx75ucQaGiGPpTbQkYztj0QLaclwImb3G63P+rSxccCQ1?=
 =?us-ascii?Q?M9GBex+nCfdwwwzyl9OwNusC20HcRO18EuIaudmcavlleNO5rXRUVvHtd3Hj?=
 =?us-ascii?Q?hmQKztUIGf5k9uMlEOkSG8wvjBT8oSqF0/Tp5ZuRjS7XdS6H3TVL+76wtnPv?=
 =?us-ascii?Q?vwzhAqfBkkZ7A9UGXprI1djOEh9u94oY22IaeokAkQiHc82XRlgiIxoLjR3x?=
 =?us-ascii?Q?PtGvAbL2RTgoW1W8tAOiqZFVUOIC1CKrjMZCrnLaAmPr8lvanNBEBMC3xUpw?=
 =?us-ascii?Q?T/0Ct9vrb80Or+XYuLQiLo6bbLRBB6mP5DiWq+kKP/i86ItBQ2c10es9G7ju?=
 =?us-ascii?Q?FDUHDvfgRGKlIdD9u7IsrUOj4Fgz+jHMXVilG20VNAf5zP5wKq1Kau7X3eam?=
 =?us-ascii?Q?vs9PZoMs36OnB7rw+MT23q2Xq7ptYdZilPJNT8h+jPWQS99AJVopV1G7LEwH?=
 =?us-ascii?Q?Vxiddxql3mqO3C7k7ro+4kGVBe5mHoP86DEMYGLiWIc31mRjgtuWjEUy2Vk9?=
 =?us-ascii?Q?gaeS1v5tiXsGkT//gqxCt886P9LR0CRB7DGITCRgGEaZGlFC9CL9BRTkC1hJ?=
 =?us-ascii?Q?02BCo1r0rnMPAbbWtCxoQXvueyUUCqcvs1vufeo/G25oLYmeGDv2YV08DV72?=
 =?us-ascii?Q?iUPlg2KVhtcugAUTJU6JI8OObXJrEdI609LjdVbykgbrcBSwR5gehkoCFVEr?=
 =?us-ascii?Q?rFGF6J0e3bwjuK87Zba6GwbrYw8R2I0tnZAvfvurNsA2Q72R9E8d+k67pe+X?=
 =?us-ascii?Q?HCxPG6aFF9Xkx1kCUPFOCGa3?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5380.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1133637e-b8ad-4a98-33c7-08d936f7e953
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2021 10:07:44.7528
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oqXFlF9ycoYLsfvRIETYvkT9E4ccneasLfvkVSphgZ/rQvVy1R8YuLylOBrdy9j1nU+4eWtyHG9be1UrJMKPqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5314
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > > > After PHY received a magic packet, the PHY WOL event will be
> > > > triggered then PHY WOL event interrupt will be disarmed.
> > > > Ethtool settings will remain with WOL enabled after a S3/S4
> > > > suspend resume cycle as expected. Hence,the driver should
> > > > reconfigure the PHY settings to reenable/disable WOL depending on
> > > > the ethtool WOL settings in the resume flow.
> > >
> > > Please could you explain this a bit more? I'm wondering if you have
> > > a PHY driver bug. PHY WOL should remain enabled until it is
> > > explicitly disabled.
> > >
> > > 	Andrew
> >
> > Let's take Marvell 1510 as example.
> >
> > As explained in driver/net/phy/marvell.c
> > 1773 >------->-------/* If WOL event happened once, the LED[2]
> > interrupt pin
> > 1774 >------->------- * will not be cleared unless we reading the
> > interrupt status
> > 1775 >------->------- * register.
> >
> > The WOL event will not able trigger again if the driver does not clear
> > the interrupt status.
> > Are we expecting PHY driver will automatically clears the interrupt
> > status rather than trigger from the MAC driver?
>=20
> So you are saying the interrupt it getting discarded? I would of though i=
t
> is this interrupt which brings to system out of suspend, and it should
> trigger the usual action, i.e. call the interrupt handler. That should th=
en
> clear the interrupt.
>=20
> 	 Andrew

No, the interrupt will not be discarded. If the PHY is in interrupt mode, t=
he
interrupt handler will triggers and ISR will clear the WOL status bit.=20
The condition here is when the PHY is in polling mode, the PHY driver does =
not
have any other mechanism to clear the WOL interrupt status bit.
Hence, we need to go through the PHY set_wol() again.=20

Weifeng