Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp94825pxv; Thu, 24 Jun 2021 03:42:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz1QZLlfhAyiEiKuNnH/UtzWooPL7UKumhDYF/dg2dYWta9wEKT1j+4Cmjm8BqDg5qd9+sJ X-Received: by 2002:a6b:d001:: with SMTP id x1mr3412969ioa.171.1624531319956; Thu, 24 Jun 2021 03:41:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624531319; cv=none; d=google.com; s=arc-20160816; b=p3SEsx4tNlofLNOJdw0QoPekX4gz/YtVooAWmqa9Zb92GCPAGIUM4+MZstqY+kHSbR wNsJrCZuC5r2NXjmyT7+ZpzCT8OyFYv4WBwotK3KV197b7hWZcagyIlsDPnQQdLggUiQ e8OZv5IEbyKFEwO7u818xTI1HvcLQz2xUENe/GKEBWdx5iz9nsVQsqc4qofAzyWo21vw qd5DiPeHGQEsCeuaPvkW0bDox6aQxko01Hc2L45DLKCAgYiRqUgqkb9MHy2Lx4u42P3x aRe7r425TrI/nWxLXZgz2403SYVidVPgpWEd31mCR5cxSd32Q3l9a7fXMnzSMxIC9nYU EF7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=/2Zk5R1tA/Y+vHgERNReTA4Bg9VjltrQTBXdKggxMXc=; b=e5XkON15yosf/pxR5CR3DB3MejxOFjNl7chDBA+XVarLF+jHT6U/Pp1TdGua615TfJ ORuIpV/wFmO88awvV6Ae4o1tIC4cf1FaJ2mJBs/EwMi5vSFKZaXQjmu/8Z5bMTW1Hgp8 ZhsAZUmVAxMIOwZ4opYc52SPPi704gSpdnwgUpoF/XFOUHnxwziSDRqpXwEwwMXnWCOS EMIlmkzWJqPiMmeyuef54ilO8wlBRNGkCkd3PUfa755Zpf/Cnd8a9tZJzllRGcVT1ltO U/iGTLntkoTzTEr/P8nalyI1Kl5d8gOEhJmhCxZaexoOxhWHgElLZgwaZQl1fXm6cQ6w O3gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=MPDX0vYs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f12si1949272ioq.84.2021.06.24.03.41.48; Thu, 24 Jun 2021 03:41:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=MPDX0vYs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232195AbhFXKng (ORCPT + 99 others); Thu, 24 Jun 2021 06:43:36 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:45745 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230008AbhFXKnd (ORCPT ); Thu, 24 Jun 2021 06:43:33 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1624531274; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=/2Zk5R1tA/Y+vHgERNReTA4Bg9VjltrQTBXdKggxMXc=; b=MPDX0vYsCQdBgxP0MrinDCQeg1dHh4arQFuj5xEoFr5gXe93yzETsNcJAWdqYARKOsLATMrf /v6xyJjTeZxfv4vUKCgUVs1wjcv5iooPtsd2lZX/GgsJ8+84J1RJGT49uGlCwjicZ1uHxxCb gToJtNEoOaSbtQsJ21K/vWsxEZU= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 60d46149ec0b18a745e9d3ba (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 24 Jun 2021 10:41:13 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 2BA47C4338A; Thu, 24 Jun 2021 10:41:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 00543C433F1; Thu, 24 Jun 2021 10:41:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 00543C433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Liwei Song Cc: Luca Coelho , David , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iwlwifi: select MAC80211_LEDS conditionally References: <20210624100823.854-1-liwei.song@windriver.com> Date: Thu, 24 Jun 2021 13:41:05 +0300 In-Reply-To: <20210624100823.854-1-liwei.song@windriver.com> (Liwei Song's message of "Thu, 24 Jun 2021 18:08:23 +0800") Message-ID: <87sg17ilz2.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Liwei Song writes: > MAC80211_LEDS depends on LEDS_CLASS=y or LEDS_CLASS=MAC80211, > add condition to enable it in iwlwifi/Kconfig to avoid below > compile warning when LEDS_CLASS was set to m: > > WARNING: unmet direct dependencies detected for MAC80211_LEDS > Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=y] && (LEDS_CLASS [=m]=y || LEDS_CLASS [=m]=MAC80211 [=y]) > Selected by [m]: > - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_INTEL [=y] && IWLWIFI [=m] && (LEDS_CLASS [=m]=y || LEDS_CLASS [=m]=IWLWIFI [=m]) && (IWLMVM [=m] || IWLDVM [=m]) > > Signed-off-by: Liwei Song Is this is a new regression or an old bug? What commit caused this? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches