Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 24 Jun 2021 13:57:08 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Alexandru Ardelean <aardelean@deviqon.com>,
        mturquette@baylibre.com, sboyd@kernel.org
Cc:     linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, pdeschrijver@nvidia.com,
        pgaikwad@nvidia.com, jonathanh@nvidia.com
Subject: Re: [PATCH] clk: tegra: clk-tegra124-dfll-fcpu: don't use devm
 functions for regulator
Message-ID: <YNRzFOIKtUZfnsu7@orome.fritz.box>
References: <20210624084737.42336-1-aardelean@deviqon.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="22riLA28tUthpble"
Content-Disposition: inline
In-Reply-To: <20210624084737.42336-1-aardelean@deviqon.com>
User-Agent: Mutt/2.0.7 (481f3800) (2021-05-04)
Precedence: bulk


--22riLA28tUthpble
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 24, 2021 at 11:47:37AM +0300, Alexandru Ardelean wrote:
> The purpose of the device-managed functions is to bind the life-time of an
> object to that of a parent device object.
>=20
> This is not the case for the 'vdd-cpu' regulator in this driver. A
> reference is obtained via devm_regulator_get() and immediately released
> with devm_regulator_put().
>=20
> In this case, the usage of devm_ functions is slightly excessive, as the
> un-managed versions of these functions is a little cleaner (and slightly
> more economical in terms of allocation).
>=20
> This change converts the devm_regulator_{get,put}() to
> regulator_{get,put}() in the get_alignment_from_regulator() function of
> this driver.
>=20
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---
>  drivers/clk/tegra/clk-tegra124-dfll-fcpu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Indeed, this seems unnecessary:

Reviewed-by: Thierry Reding <treding@nvidia.com>

Mike, Stephen: do you want to pick this up directly or would you prefer
if I collected this into a clk branch for the next cycle?

Thierry

--22riLA28tUthpble
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmDUcxEACgkQ3SOs138+
s6EqABAAiQkLJjAriym9y44MQS68pcuSdVQ8PiFo+v+2lQzGd9TyrtjtTEw1gGdf
6ogwZ1LF/Mep6JzgsekdsnMnRJ1ScyPDMbqc8qAn7euirWEXV+lLBL9yj8gKWx02
LS1pRzUhw/NAMzMZIDy65j/S4tkSmMXoeN8owAFqd2x/9uGirinRJFZ5ZdNPVnIn
WoC3KIUJ12UWYzLTAkaZMpMM83vA+0gDMCw5g2aJamopN3iKlsvimyFyC4uNVNI7
lyY1U26Q08wkSAVwA+zL5K9cwt6tx98sC8BYmqWdrTYV3V69UnUJRcH334az87ty
ssmLmozW35uP6Falfn1GODFGQh3LP4wK1ZjbHcgIGWIhwCih0JZq3pRnsuPEKbrU
wajq2BgqoaXISp0viJP4o2b5pHI6jNFxuw6//UfY58lSqasEwvXnY7Y/1dXF9QLY
hbY5vJZiUDNlXxa435aUny6jXgbN/E7vvAFna2ekd64LYjWHeEkXUYPu6mlZtHPr
oV6e9ETSpC0FP0zNuqWewiLnObJV2QmSWREHb6GkzMH/zLE8Sys0UVMlPBCf0ug9
/VzooyML8vbqINpUAeB26aYvMQMAm7Xep27QgGYUeFzbw2EPcqPDeODy8M5v7nea
pFnk+ml9Ii5DwFtxdZ1LJDOmaWjlpGpqU1iOCw8037nB0loxYeQ=
=LBAr
-----END PGP SIGNATURE-----

--22riLA28tUthpble--