Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp152794pxv;
        Thu, 24 Jun 2021 05:07:22 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxrgRVuUof/Z+ASavwknqCUR7vtWvOZpYW2VpvuysfZhqPTkeqki318zzuTWbz94uLPsjlj
X-Received: by 2002:a05:6402:5191:: with SMTP id q17mr6632146edd.321.1624536441884;
        Thu, 24 Jun 2021 05:07:21 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1624536441; cv=none;
        d=google.com; s=arc-20160816;
        b=hedOExICGCTKP7qDEqBnbwUnTluEDUBXl+ve5GsefKixo7VwdPE3ICrK5qGpotvzwZ
         VY47Cjv9UkiCp37YnUwAe3b/guibKAQQ0x63v2cUTd6zy8plCd3dotnEKuZZr2A4BSAH
         zg21ECgEvuuvgI5kZRB0N14ihLbnp2coj1OvRok3VaGaQKicz/MiBH0Dghogq5fActJs
         zH/ldaYL0wXij9GQLzj/CHg9Q+I/e1t7UIMhiGg0WV8agMFQ5BhA/NBvhAxMR2BrA2BR
         ZuOp1B7UF8Rcq1XCQCS/CgRHsx/6TRLjqEd+b7zFdWaO2QUnhfPSUh/LnbSLtvxNSDDc
         NVCQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:user-agent:references:message-id
         :in-reply-to:subject:cc:to:from:date:dkim-signature;
        bh=vc6vYrgTxC2qCy8JpK1xMKEAHkjl6DAhG4nib90QH8M=;
        b=eiJ0edR2K7/xidSDTsGEL7wYolXDiFBM1mYv/qIobiWJzQ1MmrBFFCIwoff4amYB7o
         Ddm06dzK7iurI9OObaq/1wL4QA7FzNVUivQChbornQ2xi86x6vf53WSx21PdFZLcKrQh
         RgIpwVxb1WzFqTXigsI/8CZxtcc34/NDT4TXCZDk+mqnXCRSTFYJYXZQQzSFL/kJOvzy
         YDp61nP/A0erXLLf981auJDjpvXYNKZsffEG19Yh5Y8Wazd8rnxCpgGgCikpMo9CdcwN
         cEwyQkeK8GEn+wVM1PQWhH6bnMMTuQq/JHnMJfSrozvttSgvIDheCYKvGmC+ISPSnxBi
         wMtg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EpFi0xXq;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id v29si3052503eda.351.2021.06.24.05.06.57;
        Thu, 24 Jun 2021 05:07:21 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EpFi0xXq;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230028AbhFXMHt (ORCPT <rfc822;mafatlaija@gmail.com> + 99 others);
        Thu, 24 Jun 2021 08:07:49 -0400
Received: from mail.kernel.org ([198.145.29.99]:55772 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229437AbhFXMHs (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Jun 2021 08:07:48 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id B5FDC613DC;
        Thu, 24 Jun 2021 12:05:28 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1624536329;
        bh=QRt9BUhdryDuOCzNWCyDrqVE4QwtYRomdv7yMTB/nMk=;
        h=Date:From:To:cc:Subject:In-Reply-To:References:From;
        b=EpFi0xXq/cFCB6PSCxSO0RdIf4hZ98tp7GqO7uhD7gV9megfhjyZYqp+Tzh7h2BWV
         d4atNYSky4ccXBNvKgc+KLgo4frKHw1Mhp77kWgxrL2LEqq1/xpnrhf24VJE5HLbUE
         06Of7pz4wionkM0F5MFhZ6Pc7wHApHb4Kqw+YtWJXtnhv/l6JQ/xpgVydOgh2DF9Px
         fk8+IcvNiLkQ1ATwHA7Y9jv/HXW426/EbDzgiFJ3XdTwMCMPp7PB50VlG2eqw92Z1U
         6GGyzjz7Eitn4zP6zp1hNC0hx3wz3JFPtlNjlznmLJSiZ4TG37tl1fo5jKf00RUV+Q
         PAvKV91Sc2dHQ==
Date:   Thu, 24 Jun 2021 14:05:26 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
cc:     benjamin.tissoires@redhat.com, linux-usb@vger.kernel.org,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: usbhid: hid-pidff: Fix missing error code in
 hid_pidff_init()
In-Reply-To: <1622545518-18949-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Message-ID: <nycvar.YFH.7.76.2106241405110.18969@cbobk.fhfr.pm>
References: <1622545518-18949-1-git-send-email-jiapeng.chong@linux.alibaba.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 1 Jun 2021, Jiapeng Chong wrote:

> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'error'.
> 
> Eliminate the follow smatch warning:
> 
> drivers/hid/usbhid/hid-pidff.c:1297 hid_pidff_init() warn: missing error
> code 'error'.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

This has already been fixed in hid.git via 3dd653c077efd.

Thanks,

-- 
Jiri Kosina
SUSE Labs