Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp195058pxv; Thu, 24 Jun 2021 06:04:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJze1mB5AlVsKjAXoklRQFevroJ53P3qqJl91ZpSNzLM+C6mEqEi+1qm93oKOIpM/RqtO8h7 X-Received: by 2002:adf:f90e:: with SMTP id b14mr4542509wrr.248.1624539892300; Thu, 24 Jun 2021 06:04:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624539892; cv=none; d=google.com; s=arc-20160816; b=yjdTtdvS+3ijL3v4m9fODhe1uf/U7SNqFSm36klp7f2oVim9m2F4GP28lXGv9HhAWY xETl66bhZy+0h4xHLUnud52f6wIpPBmdyMUOZkU+HovTKct2mPH/gYP5jdIryzoDIyNQ h5X9ADsWqwKRT0KE/PKSAsi8gwnt1lOmzJx+nG8n42yVQfPt9Cha7v+X8er1QdQmmEM1 eOfJnsaCa8QleYZu+yY8mvHNGNOdW/9ezdG2FAog5g/XFAuH0Xbw5BQl0+u0mE/hqXLR vo+JpW20B8eLykh2MS0vURohu47WZqMe0mXyyNvJuYqgGtRkG1HgaFrCxQJFakVAEjDI x/4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=E3eH9j6x/2bPR+R4Avd9Zya3U/JJfgeOubfcePdRb30=; b=y6wN4uLQHPsfLVjv9YS6BMuNTNTfvxGzD4IU5Fsrf5HN0Jv4LNUKH1KT8SM4lC+Q0D HeVcDFx39/uzFu1MPEAx3jPpNJLs1jUaJx42ACd04RlUGF+f0cJ3k41fnGCb3V4H+TU6 NSbhyi4d3nK6lWt/bSM/RMSSsUnazv3+u9M7EmD5zEL37mQSf76QzRg/bpTw+fxxuWIg 9p6oPynyIDa/gGCLiyXozZ615tYBEmNFM/OXgoRG52fBoUvUULsYjes5F1ZbNmAfxvu7 2spRSOiLN/0qBsPiq1xwQ8BO9OIc4R+/RR37beZXLURpd382qu3zLGp+8VKll8ESFt/S PThg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TM507lOr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bx12si2533839ejc.381.2021.06.24.06.04.23; Thu, 24 Jun 2021 06:04:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TM507lOr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231247AbhFXNF2 (ORCPT + 99 others); Thu, 24 Jun 2021 09:05:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231157AbhFXNF1 (ORCPT ); Thu, 24 Jun 2021 09:05:27 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B004C061756; Thu, 24 Jun 2021 06:03:08 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id v13so2915572ple.9; Thu, 24 Jun 2021 06:03:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=E3eH9j6x/2bPR+R4Avd9Zya3U/JJfgeOubfcePdRb30=; b=TM507lOrxyUf7DwSIdZ7SwnXqo3TOVOBtptLkJUtdPw6FUmGiD5mxOBaHx62zls0Bb TuIqQC/7Itk4IJ8J79dXkgWHrjh72TtEfoI1LmnUQI/zcKb/P9uRPzRyA5BT24wRLv/R Ip4zGeZ1zd8Px2QZM/+PSCFZJN6D44+7AEnUiBv3jEx9wQkRK9icAfNLGBe0ozsVm/0T 9XjJpBLGMC7P/68LRtijJlIPmMgyUlpDoZDGSUITbjWaAAsPhDrZTsl+vp79xS6nQt79 /g0Sn01KE1QUWzkLPTPy4yZvKct4KYxAAXFfakZ8z7Pfl8RVYmYbU/SGP/79FpzlWjKK ktzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=E3eH9j6x/2bPR+R4Avd9Zya3U/JJfgeOubfcePdRb30=; b=H7AYq/dWihGFuJLAafK3x+w1ciKJMRpB2r4Zv0RG9sRNz1py/4aersETiTRw3D4rbO tipQQGMfgsqp80o1gM7ot0LPtSca4n80MolmpmXAt/mDGQ7Zr+6ytuMffC0hs6BteJyr Y91SjJVESG+RCQ6ZfN2l0qFVbAyc7DhFoecSiMZrgHOxuW8tQryY0eHePcOkfpxG9T3G vGxlixOSEV3g+wF2nwg2jTp2uMjuL/8PFFo7ERjHBU78Ca1VdY6Fuc5bh2XOQvnifli8 p4Qu8bU3a9up+7QsrHnyHFlhI+6kIPusK+REaaWwX3jxMoFNHgRrwgV+t8q2WwLy8dGj 9kGA== X-Gm-Message-State: AOAM533l38yzgrXnStu//sjq+Km1RG6uMawMuozzs3qmCWPwxdSw0e91 2dARZ+UJ/hJ10lQdWFaC9i4= X-Received: by 2002:a17:902:da8c:b029:127:a075:cb with SMTP id j12-20020a170902da8cb0290127a07500cbmr1224288plx.26.1624539787903; Thu, 24 Jun 2021 06:03:07 -0700 (PDT) Received: from [192.168.0.118] ([103.242.196.10]) by smtp.gmail.com with ESMTPSA id z24sm1939330pfr.79.2021.06.24.06.03.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 06:03:07 -0700 (PDT) Subject: Re: [question] De-registration does not remove port To: Greg KH Cc: vgupta@synopsys.com, Jiri Slaby , linux-snps-arc@lists.infradead.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org, Pavel Andrianov References: <3e131267-e1b3-1b83-f8be-0577da479223@gmail.com> From: Saubhik Mukherjee Message-ID: <7af6c0a5-c990-5a40-104e-13f44b1cb4c5@gmail.com> Date: Thu, 24 Jun 2021 18:33:01 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/23/21 12:44 PM, Greg KH wrote: > On Wed, Jun 23, 2021 at 11:42:36AM +0530, Saubhik Mukherjee wrote: >> In drivers/tty/serial/arc_uart.c, arc_serial_remove always returns 0, >> instead of calling uart_remove_one_port to remove uart port from serial >> core. The comment says "This will be never be called". In my understanding, >> a port added using uart_add_one_port should be removed during >> de-registration. >> >> Is there a reason for this behavior? > > Did you test the code to see if that function will ever be called? I would like to reformulate the question: Suppose arc_serial_remove is never called. Then I would like to know how the driver de-registration is organized since the UART port is never removed?