Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 24 Jun 2021 15:41:30 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     =?ISO-8859-15?Q?Thomas_Wei=DFschuh?= <linux@weissschuh.net>
cc:     linux-input@vger.kernel.org,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Hans de Goede <hdegoede@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] HID: input: Add support for Programmable Buttons
In-Reply-To: <20210615214103.1031479-1-linux@weissschuh.net>
Message-ID: <nycvar.YFH.7.76.2106241541190.18969@cbobk.fhfr.pm>
References: <20210615214103.1031479-1-linux@weissschuh.net>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Tue, 15 Jun 2021, Thomas Weißschuh wrote:

> Map them to KEY_MACRO# event codes.
> 
> These buttons are defined by HID as follows:
> "The user defines the function of these buttons to control software applications or GUI objects."
> 
> This matches the semantics of the KEY_MACRO# input event codes that Linux supports.
> 
> Also add support for HID "Named Array" collections.
> Also add hid-debug support for KEY_MACRO#.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> 
> ---
> 
> v1: https://lore.kernel.org/linux-input/20210519160349.609690-1-linux@weissschuh.net/
> 
> v1 -> v2: Only handle the 30 keys known
> 
> v2: https://lore.kernel.org/linux-input/20210519174345.614467-1-linux@weissschuh.net/
> 
> v2 -> v3:
>  * Use hex constants for consistency
>  * Validate that the button is part of a "Programmable Buttons" Named Array.
>    Otherwise the condition would also apply to "Function Buttons".
>  * Ignore non-"Programmable Buttons" buttons.
> 
> v3: https://lore.kernel.org/linux-input/20210520084805.685486-1-linux@weissschuh.net/
> 
> v3 -> v4:
>  * Mention new support for HID "Named Array" collections in commit message.
>  * Mention new support KEY_MACRO# in hid-debug.

Applied, thank you.

-- 
Jiri Kosina
SUSE Labs