Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1623749684-65432-1-git-send-email-liuqi115@huawei.com>
 <1623749684-65432-2-git-send-email-liuqi115@huawei.com> <20210623225111.GA1057775@p14s>
 <0aac4467-3abc-026c-4989-22b87bc80dc7@huawei.com>
In-Reply-To: <0aac4467-3abc-026c-4989-22b87bc80dc7@huawei.com>
From:   Mathieu Poirier <mathieu.poirier@linaro.org>
Date:   Thu, 24 Jun 2021 10:26:13 -0600
Message-ID: <CANLsYkyCGO6tVn7WWfw6BPJwsHPT6dbWmXHXAzEh8X-x=2ENGg@mail.gmail.com>
Subject: Re: [RFC PATCH 1/4] Documentation: tracing: Documentation for
 ultrasoc framework and drivers
To:     "liuqi (BA)" <liuqi115@huawei.com>
Cc:     Linuxarm <linuxarm@huawei.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        "Suzuki K. Poulose" <suzuki.poulose@arm.com>,
        Jonathan Zhou <jonathan.zhouwen@huawei.com>,
        f.fangjian@huawei.com,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Coresight ML <coresight@lists.linaro.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> >> +Example usage of perf::
> >> +
> >> +     $# ./perf list pmu
> >> +     cs_etm//                                    [Kernel PMU event]
> >> +    $# ./perf record -e cs_etm/@sink_smb0/ -C 0 --per-thread sleep 2s
> >> +    [ perf record: Woken up 2 times to write data ]
> >> +    [ perf record: Captured and wrote 0.288 MB perf.data ]
> >> +    $# ./perf report
> >
> > After reading all this and without looking at the rest of the patchset it seems
> > to me this work should go under drivers/hwtracing/coresight/.
> >
>
> So how about drivers/hwtracing/coresight/ultrasoc?
>

It's hard to say at this time - I'll advise further once I have
reviewed the other patches.

> > There is a lot of code to review and as such it will take me a fair amount of
> > time to go through it all.  Comments will be scattered over several days (weeks)
> > - I will set you know when I am done.
> >
> > Thanks,
> > Mathieu
>
> Ok, thanks for revewing this patchset
>
> Qi
> >
> >> --
> >> 2.7.4
> >>
> > .
> >
>