Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 24 Jun 2021 17:31:34 +0000
From:   Sean Christopherson <seanjc@google.com>
To:     Tom Lendacky <thomas.lendacky@amd.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Peter Gonda <pgonda@google.com>,
        Brijesh Singh <brijesh.singh@amd.com>
Subject: Re: [PATCH 0/7] KVM: x86: guest MAXPHYADDR and C-bit fixes
Message-ID: <YNTBdvWxwyx3T+Cs@google.com>
References: <20210623230552.4027702-1-seanjc@google.com>
 <324a95ee-b962-acdf-9bd7-b8b23b9fb991@amd.com>
 <c2d7a69a-386e-6f44-71c2-eb9a243c3a78@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c2d7a69a-386e-6f44-71c2-eb9a243c3a78@amd.com>
Precedence: bulk

On Thu, Jun 24, 2021, Tom Lendacky wrote:
> > 
> > Here's an explanation of the physical address reduction for bare-metal and
> > guest.
> > 
> > With MSR 0xC001_0010[SMEE] = 0:
> >   No reduction in host or guest max physical address.
> > 
> > With MSR 0xC001_0010[SMEE] = 1:
> > - Reduction in the host is enumerated by CPUID 0x8000_001F_EBX[11:6],
> >   regardless of whether SME is enabled in the host or not. So, for example
> >   on EPYC generation 2 (Rome) you would see a reduction from 48 to 43.
> > - There is no reduction in physical address in a legacy guest (non-SEV
> >   guest), so the guest can use a 48-bit physical address

So the behavior I'm seeing is either a CPU bug or user error.  Can you verify
the unexpected #PF behavior to make sure I'm not doing something stupid?

Thanks!

> > - There is a reduction of only the encryption bit in an SEV guest, so
> >   the guest can use up to a 47-bit physical address. This is why the
> >   Qemu command line sev-guest option uses a value of 1 for the
> >   "reduced-phys-bits" parameter.
> > 
> 
> The guest statements all assume that NPT is enabled.
> 
> Thanks,
> Tom