Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210621100519.10257-1-colin.king@canonical.com>
In-Reply-To: <20210621100519.10257-1-colin.king@canonical.com>
From:   Ryusuke Konishi <konishi.ryusuke@gmail.com>
Date:   Fri, 25 Jun 2021 02:34:38 +0900
Message-ID: <CAKFNMomw60BGObwF2ZOFriFwPnEk5hFZgC-5vJwJjPnrW3RyPw@mail.gmail.com>
Subject: Re: [PATCH] nilfs2: remove redundant continue statement in a while-loop
To:     Colin King <colin.king@canonical.com>
Cc:     linux-nilfs <linux-nilfs@vger.kernel.org>,
        kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Thank you.  This change is correct also in view of the expected
behavior of the function
(it really is unnecessary).
I will send this to upstream.

Regards,
Ryusuke Konishi

On Mon, Jun 21, 2021 at 7:05 PM Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The continue statement at the end of the while-loop is redundant,
> remove it.
>
> Addresses-Coverity: ("Continue has no effect")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  fs/nilfs2/btree.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/nilfs2/btree.c b/fs/nilfs2/btree.c
> index f42ab57201e7..ab9ec073330f 100644
> --- a/fs/nilfs2/btree.c
> +++ b/fs/nilfs2/btree.c
> @@ -738,7 +738,6 @@ static int nilfs_btree_lookup_contig(const struct nilfs_bmap *btree,
>                         if (ptr2 != ptr + cnt || ++cnt == maxblocks)
>                                 goto end;
>                         index++;
> -                       continue;
>                 }
>                 if (level == maxlevel)
>                         break;
> --
> 2.31.1
>