Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp476485pxv; Thu, 24 Jun 2021 12:09:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3PJvI/3mLnMKEfOEMVPNjvqF6E7twivrLFgALwAxHD2NkeypwTXCXf972X60x3rp3twMp X-Received: by 2002:aa7:dbc8:: with SMTP id v8mr5876176edt.242.1624561768454; Thu, 24 Jun 2021 12:09:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624561768; cv=none; d=google.com; s=arc-20160816; b=xj5TvaeQdMUu09X+QCUA1BNSgPDzLEJqvkuTOvXoXPWr92WiUytltgpgoDO3Z21JAF oo9s4/TWyceAy6mDGNkrkC3a5qib4YGYOLxwYUeVoBNvaDpmN7RY5DdvXBDb9MvNZh8b JxTDjugjErN98QzM169WlznwcZHNZtiLBCmmBg4L/dt3vc0f5w/LtE3mM9+XIWEbQ8cb H9m7PIcaztmwJdyAI6WWeBCWHWaXYhg5MMyBazeWKu0Xd+Sz3zIw7dXVYyQUXz99+Kcp 72VT6GIIfLucdINqlC0AY75+PmZoF7+uZ5METoB6zycrZqtCMaasQesUpkXXGFMwGtyW LUuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=sASZIh0JylD5nlffYVNx6Q2qk0hslOsxCidZn+CssBE=; b=aVzX4sEkz6QGpaRknBSVsNFYxB4ivFUQUS9qXZ7wBiL8MegmWREVeU/RQbK/oyvosV G5iYXcWjJbss8tM6IXwjPB4x0LLG6bNO/HnKWZVHshn8lql6cccv+nZrq03Yt68Eqz6H T20Xux0aUV33p/fuYZ1v31YhvVtgz+Nr+cp4uxn9XH4JeeOZTYrogcdmecyuUdFOXfqb dbNRWdbDaA1+EteYP6dbg1zFzrl0aBjZuiytelNWOMYVINJruPiAQFseNNFfiW2OIGS0 U08Lwg6usP64l8S3vtlXV1tNvDBrzi6TBFidlWrQSg8lFNSm2zmdWNaWnhsD5r8TpwGQ lktA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q20si4315028ejb.115.2021.06.24.12.09.04; Thu, 24 Jun 2021 12:09:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232626AbhFXTIZ (ORCPT + 99 others); Thu, 24 Jun 2021 15:08:25 -0400 Received: from mail-il1-f179.google.com ([209.85.166.179]:35353 "EHLO mail-il1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232417AbhFXTIY (ORCPT ); Thu, 24 Jun 2021 15:08:24 -0400 Received: by mail-il1-f179.google.com with SMTP id a11so7431588ilf.2; Thu, 24 Jun 2021 12:06:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sASZIh0JylD5nlffYVNx6Q2qk0hslOsxCidZn+CssBE=; b=umL6sQhl5HZD3O3PpEjqmOlhLccyc+N5YKxKGN+0bcxgLNRvpTdV5emgBkyVXEsv4x GLTJfoZoTpXRVkk9ZFVOOy+Yxz0w0gOQYJrfxQKcYTSKnjoS3eDCkYmuuOxjw7ZCTKK5 +Dc8BK+y0vK184JRMAzEb3vlmT/6002nuHcmZkru0f/ihNPuC7AF5kj7t0Nz4Dd6R4Nu a/pwYLCEGHJIhQKwdZAH0jjvgn/PW5kutZp4e+JP2lQTWVEtL+ssExgT5+bllQX/uhul hwE1IsOrq4IXSb+/Qk4lkiMsx71tNM2gFtwZF7PE0es8KE76o5YjYULCsN7U+zAEAQeg /3Xw== X-Gm-Message-State: AOAM532xmQ0FcXsxbJGrgK6HbumxnO4IhAmzrDX9p8NSO+6iokOV4/YG yvrN3DxGU9xYEtOjt+6ZDQ== X-Received: by 2002:a05:6e02:1aa7:: with SMTP id l7mr4537589ilv.187.1624561564334; Thu, 24 Jun 2021 12:06:04 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id h8sm975531ile.45.2021.06.24.12.06.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 12:06:02 -0700 (PDT) Received: (nullmailer pid 1820092 invoked by uid 1000); Thu, 24 Jun 2021 19:05:58 -0000 Date: Thu, 24 Jun 2021 13:05:58 -0600 From: Rob Herring To: Dong Aisheng Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, Rob Herring , devicetree@vger.kernel.org, dongas86@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] of: of_reserved_mem: only call memblock_free for normal reserved memory Message-ID: <20210624190558.GA1819995@robh.at.kernel.org> References: <20210611131153.3731147-1-aisheng.dong@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210611131153.3731147-1-aisheng.dong@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Jun 2021 21:11:52 +0800, Dong Aisheng wrote: > For nomap case, the memory block will be removed by memblock_remove() > in early_init_dt_alloc_reserved_memory_arch(). So it's meaningless to > call memblock_free() on error path. > > Cc: Rob Herring > Cc: devicetree@vger.kernel.org > Signed-off-by: Dong Aisheng > --- > drivers/of/of_reserved_mem.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Applied, thanks!