Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp487597pxv; Thu, 24 Jun 2021 12:26:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvBn/0cxltXs3XNzxNBHOll2+18W+5E+oZTYdnwTnRXEWE5cJNt3byc86M1hNE909uODcS X-Received: by 2002:a17:907:2648:: with SMTP id ar8mr6850417ejc.77.1624562796708; Thu, 24 Jun 2021 12:26:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624562796; cv=none; d=google.com; s=arc-20160816; b=PY+fJhXWwZfwpAwdB2+zPEQUT3mc2oXx9M7LDE0f+L+ShPky7NFtwQcgpONKqliWyg ZTDr6Kx0/RWAwS6VkeW2ldgQ4HWgv0s92jJ0na4zlXbZIPTJMLh+SJEaOxUoKDCI0o2o o6zIce8NAPULSDXWo2V7+U3cXWkhHBn5Ao5FEiDEfJadmwrrguIG2XTpCbnxmo995wki UEu9JOrjJ9lLuXLoDtkKuOv71eNc9c0dEkwKlqYNsasbdEiKRBIfwhsgCFnppNE1T1BQ Uxiwn+bqi2yLWukQul2RI10W5w2YT8U9K+XWj8LP65Vo7ALjUUejExlvJR7Co7BqA/dZ V2XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xeb0sNS4CcBPblr7Wash2SqMyTwQ1wPtAmhQBuE5IwI=; b=LjTagSstBhWL576Ll9UUSCVgzfpPlEQ9Rvuo9fdlmkpc3KMNelJfYQVOvCCzlHXy4O Mmz/DqoyUk6caueYGpiMYyzLyInpyCiXldn3ZlPx/TxeBUL8cnuoHZ2Wkyhq3BsO+faG e2PJgHjA45aQ0eP+O9xcJmErH6tt4uhxL/raowoWZdAto8U4zX63uwdwJc9VPebooqS9 stmUzg8bJT6me8k/BFUuaJjeOL/iIMWTsg3f0fIDwzCvWCSai+QEdhSxA7p5jhhMYupM attd8xdRDFp7xUJH/iZTlX6bDtEVZ6PnD5FIwX2qGz16/jRsp4LQgEljGO7wQQf8WZ4k Pqkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=HYDVMqFq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ar14si3531551ejc.276.2021.06.24.12.26.13; Thu, 24 Jun 2021 12:26:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=HYDVMqFq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232849AbhFXTZL (ORCPT + 99 others); Thu, 24 Jun 2021 15:25:11 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:51344 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232838AbhFXTY6 (ORCPT ); Thu, 24 Jun 2021 15:24:58 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 15OJMaO7043505; Thu, 24 Jun 2021 14:22:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1624562556; bh=xeb0sNS4CcBPblr7Wash2SqMyTwQ1wPtAmhQBuE5IwI=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=HYDVMqFqRdNeAinm6YHagupsZ+1zrfLdgpBirPOkYbjy5I14coI8/ywduwiZphG7o 4NAPwHF3CPmU26+vYxQceRqx/Uxon02F5VDpuUpf1rIqBI4qrD5vkV+OVRftWd9fo3 ggVD1rzrcPbJxW49JpuGhH7UGf4+ilXE+uISJhA8= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 15OJMaGM028224 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 24 Jun 2021 14:22:36 -0500 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 24 Jun 2021 14:22:36 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Thu, 24 Jun 2021 14:22:36 -0500 Received: from pratyush-OptiPlex-790.dhcp.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 15OJM14N120548; Thu, 24 Jun 2021 14:22:34 -0500 From: Pratyush Yadav To: Mauro Carvalho Chehab CC: Laurent Pinchart , Vignesh Raghavendra , Tomi Valkeinen , Nikhil Devshatwar , Pratyush Yadav , Maxime Ripard , , Subject: [PATCH v3 07/11] media: cadence: csi2rx: Populate subdev devnode Date: Fri, 25 Jun 2021 00:51:56 +0530 Message-ID: <20210624192200.22559-8-p.yadav@ti.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210624192200.22559-1-p.yadav@ti.com> References: <20210624192200.22559-1-p.yadav@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The devnode can be used by media-ctl and other userspace tools to perform configurations on the subdev. Without it, media-ctl returns ENOENT when setting format on the sensor subdev. Signed-off-by: Pratyush Yadav --- (no changes since v2) Changes in v2: - New in v2. drivers/media/platform/cadence/cdns-csi2rx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c index 780b42df757a..ff893a29ea54 100644 --- a/drivers/media/platform/cadence/cdns-csi2rx.c +++ b/drivers/media/platform/cadence/cdns-csi2rx.c @@ -609,6 +609,7 @@ static int csi2rx_probe(struct platform_device *pdev) csi2rx->pads[CSI2RX_PAD_SINK].flags = MEDIA_PAD_FL_SINK; for (i = CSI2RX_PAD_SOURCE_STREAM0; i < CSI2RX_PAD_MAX; i++) csi2rx->pads[i].flags = MEDIA_PAD_FL_SOURCE; + csi2rx->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; ret = media_entity_pads_init(&csi2rx->subdev.entity, CSI2RX_PAD_MAX, csi2rx->pads); -- 2.30.0