Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 24 Jun 2021 22:10:17 +0200
From:   Wolfram Sang <wsa@kernel.org>
To:     Johan Hovold <johan@kernel.org>
Cc:     linux-i2c@vger.kernel.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        syzbot+9d7dadd15b8819d73f41@syzkaller.appspotmail.com,
        stable@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] i2c: robotfuzz-osif: fix control-request directions
Message-ID: <YNTmqcrYb9KzW8Zh@kunai>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Johan Hovold <johan@kernel.org>, linux-i2c@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        syzbot+9d7dadd15b8819d73f41@syzkaller.appspotmail.com,
        stable@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>
References: <20210524090912.3989-1-johan@kernel.org>
 <YNL2NLSpBQqnc2bH@hovoldconsulting.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="MKR9idyquUPZmLcd"
Content-Disposition: inline
In-Reply-To: <YNL2NLSpBQqnc2bH@hovoldconsulting.com>
Precedence: bulk


--MKR9idyquUPZmLcd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 23, 2021 at 10:52:04AM +0200, Johan Hovold wrote:
> On Mon, May 24, 2021 at 11:09:12AM +0200, Johan Hovold wrote:
> > The direction of the pipe argument must match the request-type direction
> > bit or control requests may fail depending on the host-controller-driver
> > implementation.
> >=20
> > Control transfers without a data stage are treated as OUT requests by
> > the USB stack and should be using usb_sndctrlpipe(). Failing to do so
> > will now trigger a warning.
> >=20
> > Fix the OSIFI2C_SET_BIT_RATE and OSIFI2C_STOP requests which erroneously
> > used the osif_usb_read() helper and set the IN direction bit.
> >=20
> > Reported-by: syzbot+9d7dadd15b8819d73f41@syzkaller.appspotmail.com
> > Fixes: 83e53a8f120f ("i2c: Add bus driver for for OSIF USB i2c device.")
> > Cc: stable@vger.kernel.org      # 3.14
> > Cc: Andrew Lunn <andrew@lunn.ch>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
>=20
> Wolfram, can you pick this one up for 5.14?

Sorry, I thought Andrew was the maintainer of this driver and was
waiting for his ack. But he is not, this driver is unmaintained. So, I
trust you and picked it up now.

Applied to for-current, thanks!


--MKR9idyquUPZmLcd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmDU5qgACgkQFA3kzBSg
KbZA9BAAlhZEQnPgQHEocCgFHoL1zsrDnKA9gZn+wDnz7rH0OwCm0/lIWwB8+qxb
UyFLr+8weobCh+gN84wlMf2CFa7gGJd+rbZotd6UE33SyCehMkO1HRiZ452W3uLn
f64KzEkj3IR3HQ8LjijdssCveh+B0IbP6ggtQ6d6GPUbVXDINk2xdyAH+NlOr01L
ga2oPVSH8iOGsG2BLRE84e69jVzdJ3RikE9F6SalellJLfbAurOShwpuwW2is4ym
2bIDvdX/LFj4vlT68LVY54KBpmpXMv3/tunFMPKvJkntsURLSGZJ+6XHbwOMAixT
6bfyE+RDSxxKp0Z3cRvsR7BQlL618Yze34SDHTCpmcvZOHAR2o9nEr9Xf/5dc5+B
msh/2gY2H71+1aTE0o/bqzs9Igqih641uboiCYiVu+CLZ/QHij1GtfAkROV0N2Uu
wnw42od3gc3+BhTtnbqQi4epzA9RMsLtQ3dMzWoEahIQYS23w8yqUo+IjVRiFWNE
rNlxA5qyA/VHFBjBVAVNNC+lleAhVBC2xr/r1PqQGn0n66neakAyf73EOS0SfXER
fmdR1/qnLfEoa+wCOVha7SwOHYbxG7tXVJw5mwjOdaNflGIc96tOdx0WdLfMJ4eE
dnweudbMJ6MOaG60+2Qx/rCVeQdqTPSQKvN5ES3MBRwYRdvZlCo=
=Tg0E
-----END PGP SIGNATURE-----

--MKR9idyquUPZmLcd--