Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp572992pxv; Thu, 24 Jun 2021 14:38:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5alOYNcHbGplWyYt63fRvmbQlBjiyE4FQ9zFE3FLN8G7P+SrDaEWVXt+PTwBn/1dbaqmw X-Received: by 2002:a5d:904c:: with SMTP id v12mr5675116ioq.95.1624570736376; Thu, 24 Jun 2021 14:38:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624570736; cv=none; d=google.com; s=arc-20160816; b=LI0g1mDgwvIx45gPSkesIM7GIzH03TVyr7cisuU7dSuVxSwEiNG3TnMs6I6kIgJAVi nMZsnh1uRQ6ruTX5Ei37Q5yZBUwDzBWsXfnDnXMVaeKZ5JuTp5eQS58hJY+cBTjmlpVC 5xh+BHYIEOH7jsmTnjC8inswUQi3WSihvHRYe+xRi+0LjB6roWkIcSDkp8l1InnKHXMm 9Z4C85Q/eskS8pA/TAAfjQkQjFRsh5rGekNBFSya7u+7TQeFdL4ChEkXGym+ACX9bww8 t41WLzaUnDdCGcDxr+/61owMhyqk22h27zYjJ+KsiGuaWSJ6JSi2ZHzyzTYRh7VpYeR4 OWAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:mime-version:user-agent:message-id :in-reply-to:date:references:cc:to:from; bh=xZQUQWmiR158aIKR4fWHRHRTuflr7pLpmna2ubI+FvQ=; b=ZGVzFlGuc23c7wJlfqUmoWOKBV8k3uv1O74CCPwyXlcByjQMk412FeXmz+SsjNi8l7 c+QL/M2C8MMpT3tQ+PzdybnFEtyCKfLROJmRxjZO5tYkepJZk+k+GXJjr0LEjjirVlF7 svr8lMJEBH+pD90IWilmyGawkYubden1bnRcNzRPt5r2tVfSRxNLDDGT77MW8cphVbcf QoEeZ3DSeZZqCnDnlDMmNbm55dTTOsQ2mPtJVYIU3+ZrzX9mKK6sel7VLCMIRYNqHByc TVK98/LMPt6wGoKlSbraGyscr3PUG1YzTDw/wo7aM8MYTF4YI+ns5y8oJwou5NaOXXMx UvKA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j5si3687230ioj.35.2021.06.24.14.38.44; Thu, 24 Jun 2021 14:38:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232650AbhFXVk1 (ORCPT + 99 others); Thu, 24 Jun 2021 17:40:27 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:59776 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232029AbhFXVk0 (ORCPT ); Thu, 24 Jun 2021 17:40:26 -0400 Received: from in02.mta.xmission.com ([166.70.13.52]:34726) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lwX2z-008su7-FE; Thu, 24 Jun 2021 15:38:05 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95]:51012 helo=email.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lwX2y-003iue-41; Thu, 24 Jun 2021 15:38:05 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Linus Torvalds Cc: Al Viro , Michael Schmitz , linux-arch , Jens Axboe , Oleg Nesterov , Linux Kernel Mailing List , Richard Henderson , Ivan Kokshaysky , Matt Turner , alpha , Geert Uytterhoeven , linux-m68k , Arnd Bergmann , Tejun Heo , Kees Cook References: <87sg1lwhvm.fsf@disp2133> <6e47eff8-d0a4-8390-1222-e975bfbf3a65@gmail.com> <924ec53c-2fd9-2e1c-bbb1-3fda49809be4@gmail.com> <87eed4v2dc.fsf@disp2133> <5929e116-fa61-b211-342a-c706dcb834ca@gmail.com> <87fsxjorgs.fsf@disp2133> <87a6njf0ia.fsf@disp2133> <87tulpbp19.fsf@disp2133> <87zgvgabw1.fsf@disp2133> <875yy3850g.fsf_-_@disp2133> <87y2az5bmt.fsf_-_@disp2133> Date: Thu, 24 Jun 2021 16:37:19 -0500 In-Reply-To: (Linus Torvalds's message of "Thu, 24 Jun 2021 13:11:18 -0700") Message-ID: <87a6nf54hc.fsf@disp2133> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1lwX2y-003iue-41;;;mid=<87a6nf54hc.fsf@disp2133>;;;hst=in02.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18LalAUym3BX/fF3gpKr2RXYRq1CIkZYD0= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa07.xmission.com X-Spam-Level: ** X-Spam-Status: No, score=2.0 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01,XMNoVowels, XMSubLong autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4999] * 0.7 XMSubLong Long Subject * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;Linus Torvalds X-Spam-Relay-Country: X-Spam-Timing: total 368 ms - load_scoreonly_sql: 0.06 (0.0%), signal_user_changed: 11 (3.0%), b_tie_ro: 10 (2.6%), parse: 0.98 (0.3%), extract_message_metadata: 16 (4.2%), get_uri_detail_list: 1.16 (0.3%), tests_pri_-1000: 26 (7.2%), tests_pri_-950: 1.31 (0.4%), tests_pri_-900: 1.10 (0.3%), tests_pri_-90: 63 (17.2%), check_bayes: 61 (16.7%), b_tokenize: 8 (2.1%), b_tok_get_all: 8 (2.3%), b_comp_prob: 2.6 (0.7%), b_tok_touch_all: 39 (10.6%), b_finish: 0.99 (0.3%), tests_pri_0: 236 (64.3%), check_dkim_signature: 0.66 (0.2%), check_dkim_adsp: 3.0 (0.8%), poll_dns_idle: 0.85 (0.2%), tests_pri_10: 2.1 (0.6%), tests_pri_500: 7 (1.8%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 7/9] signal: Make individual tasks exiting a first class concept. X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds writes: > On Thu, Jun 24, 2021 at 12:03 PM Eric W. Biederman > wrote: >> >> Implement start_task_exit_locked and rewrite the de_thread logic >> in exec using it. >> >> Calling start_task_exit_locked is equivalent to asyncrhonously >> calling exit(2) aka pthread_exit on a task. > > Ok, so this is the patch that makes me go "Yeah, this seems to all go together". > > The whole "start_exit()" thing seemed fairly sane as an interesting > concept to the whole ptrace notification thing, but this one actually > made me think it makes conceptual sense and how we had exactly that > "start exit asynchronously" case already in zap_other_threads(). > > So doing that zap_other_threads() as that async exit makes me just > thin kthat yes, this series is the right thing, because it not only > cleans up the ptrace condition, it makes sense in this entirely > unrelated area too. > > So I think I'm convinced. I'd like Oleg in particular to Ack this > series, and Al to look it over, but I do think this is the right > direction. Thanks. It took a bit of exploration and playing with things to get here, but I had the same sense. Next round I will see if I can clean up the patches a bit more. Eric