Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp617121pxv; Thu, 24 Jun 2021 15:53:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3Om/tlxc7F2fhGDPtYU2di0M13ikrLa1zZeJtiMmqw7pUHDbAMlkNmF/Ft5VzeF+rQ4Q/ X-Received: by 2002:a17:906:ae99:: with SMTP id md25mr7522240ejb.14.1624575194281; Thu, 24 Jun 2021 15:53:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624575194; cv=none; d=google.com; s=arc-20160816; b=gvE8D50A9fQ96gyJYPd1HpoRv3UCuxR5hO29DwW44RvFEIpJ038HbvbfMLwibu0cpb +sRlk5Er8L0AIiRqZLBDcCneqClvjdRy66r1MFYMXgH28J2E6Ilsz5VpisOyTqQt1C13 JnASKWwQz7cMv61IKtOR1uAuISrDecM+F717ksRUNfhi1zr8s4Xqq6ojx+IRixLZ/YPT bz1EW4yUq+lZJmo2wYIjF6sbog3lHlvmZIBQnoSpWfh70qEcZsvjUvkj3w6WvVF2GSNF +rZnOrvb0s1xscgpCSKqzTjG17BYkwFFh/n+UscjMvIsMcH0GC3OptKNkSb3mCtCu9bS jtRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yhcMw6tAi3O3Tm4HTDmvGT7E03PLFJwBAG2l2ewlAeM=; b=tP+4a6VIGodIfM6WY/yx4Jxpe9u1pkAZSFJ4l9c4B/SDVxgeGUxSgXivP3R02XKIpv MhVgoygenmkHki5bU72cQ0DFAAYdCeZFHFtLoycASUul+E4QvpCHPqNCyngPzLfUYOkn s16uQNYHkEloNr3xmg113yxgbrJBFa2xzfshU62TzUWE71ArVLR3/shwpzZAwdT4PvQg gKK+gM5x75w8dQM6sedyXWA9YyBLJ1yiXspP/SKSQwdqJfFojOtGgA8d8Wbg/dvnVM02 FdR+myzmVMXq5gQTIeS9cV5VrGHxhAcNUlCopN8lKuTFdRo0rpaZRkeqpw8SP0WOdm1M Jr6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=g9bBPTgF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j20si4176097edw.80.2021.06.24.15.52.51; Thu, 24 Jun 2021 15:53:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=g9bBPTgF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232927AbhFXWwY (ORCPT + 99 others); Thu, 24 Jun 2021 18:52:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:54486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232582AbhFXWwN (ORCPT ); Thu, 24 Jun 2021 18:52:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 64A646138C; Thu, 24 Jun 2021 22:49:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624574993; bh=P00gi1Wtx+KpLLM7s98I0ogOiO2aXZ3GHASm7R/VtvA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g9bBPTgFeD0qqieH/lPBvJiObWbeFCEHUcEWkYen5KPGeK7QBzRy1NGruRfHbAyUM lX+bQ05uQYIT0QRZ4zMyZqjYItXQEeYUR3+rtYnpT9NnVRVx+Byl3tcZy/O5leYFPo RE8E72bwDLEz7/Z0tMyKk2TFo1t8ShjvnmES49GtNHlZEZg6hL8Ri4R6rv9G4TmOnx /yKi4PsdpAG8iuAr4LDnAK9ozaEN1pfuaMGe5eYdHSxz7vtR2N4zqUEeXsi3J5V0HV M1v+ns5GIsH6Zs+ZxQO0pwdXBkuv4paXjAixfKjXe0O/5JUZ9fya34MfkJa6EWVX1U wQv8Ai7t+Ahwg== Received: by pali.im (Postfix) id 87A7896D; Fri, 25 Jun 2021 00:49:51 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Michael Turquette , Stephen Boyd , Rob Herring , Greg Kroah-Hartman Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Vid , =?UTF-8?q?Marek=20Beh=C3=BAn?= , linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 01/10] serial: mvebu-uart: fix calculation of clock divisor Date: Fri, 25 Jun 2021 00:49:00 +0200 Message-Id: <20210624224909.6350-2-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210624224909.6350-1-pali@kernel.org> References: <20210624224909.6350-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The clock divisor should be rounded to the closest value. Signed-off-by: Pali Rohár Fixes: 68a0db1d7da2 ("serial: mvebu-uart: add function to change baudrate") Cc: stable@vger.kernel.org # 0e4cf69ede87 ("serial: mvebu-uart: clarify the baud rate derivation") --- drivers/tty/serial/mvebu-uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c index e0c00a1b0763..f81bfdaa608c 100644 --- a/drivers/tty/serial/mvebu-uart.c +++ b/drivers/tty/serial/mvebu-uart.c @@ -463,7 +463,7 @@ static int mvebu_uart_baud_rate_set(struct uart_port *port, unsigned int baud) * makes use of D to configure the desired baudrate. */ m_divisor = OSAMP_DEFAULT_DIVISOR; - d_divisor = DIV_ROUND_UP(port->uartclk, baud * m_divisor); + d_divisor = DIV_ROUND_CLOSEST(port->uartclk, baud * m_divisor); brdv = readl(port->membase + UART_BRDV); brdv &= ~BRDV_BAUD_MASK; -- 2.20.1