Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] tpm, tpm_tis_spi: Allow to sleep in the interrupt
 handler
To:     Jarkko Sakkinen <jarkko@kernel.org>
Cc:     peterhuewe@gmx.de, jgg@ziepe.ca, linus.walleij@linaro.org,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
References: <20210620023444.14684-1-LinoSanfilippo@gmx.de>
 <20210623133420.gw2lziue5nkvjtps@kernel.org>
From:   Lino Sanfilippo <LinoSanfilippo@gmx.de>
Message-ID: <5fbe3f44-8c0d-f185-45fd-fcaa7af3657d@gmx.de>
Date:   Fri, 25 Jun 2021 02:17:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210623133420.gw2lziue5nkvjtps@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On 23.06.21 at 15:34, Jarkko Sakkinen wrote:
> On Sun, Jun 20, 2021 at 04:34:44AM +0200, Lino Sanfilippo wrote:
>> Interrupt handling at least includes reading and writing the interrupt
>> status register within the interrupt routine. For accesses over SPI a m=
utex
>> is used in the concerning functions. Since this requires a sleepable
>> context request a threaded interrupt handler for this case.
>>
>> Cc: stable@vger.kernel.org
>> Fixes: 1a339b658d9d ("tpm_tis_spi: Pass the SPI IRQ down to the driver"=
)
>> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
>
> I'll test this after rc1 PR (I have one NUC which uses tpm_tis_spi).
>
> /Jarkko
>

Sounds great, thank you!

Regards,
Lino