Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210416172147.8736-1-cccheng@synology.com>
In-Reply-To: <20210416172147.8736-1-cccheng@synology.com>
From:   Chung-Chiang Cheng <shepjeng@gmail.com>
Date:   Fri, 25 Jun 2021 11:07:34 +0800
Message-ID: <CAHuHWtkqMeT3UwKH3zMr5j782U9UcwrdjXdqVHLND2MLi8rQKg@mail.gmail.com>
Subject: Re: [PATCH] hfsplus: report create_date to kstat.btime
To:     christian.brauner@ubuntu.com, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, jamorris@linux.microsoft.com,
        axboe@kernel.dk, dhowells@redhat.com,
        ernesto.mnd.fernandez@gmail.com, Al Viro <viro@zeniv.linux.org.uk>
Cc:     "Synology/Chung-Chiang Cheng" <cccheng@synology.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

From: Chung-Chiang Cheng <cccheng@synology.com>

There's no HFSPLUS maintainer now. Could anyone help to review this
patch or give feedback?

On Sat, Apr 17, 2021 at 1:21 AM Chung-Chiang Cheng <shepjeng@gmail.com> wrote:
>
> The create_date field of inode in hfsplus is corresponding to kstat.btime
> and could be reported in statx.
>
> Signed-off-by: Chung-Chiang Cheng <cccheng@synology.com>
> ---
>  fs/hfsplus/inode.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c
> index 078c5c8a5156..aab3388a0fd7 100644
> --- a/fs/hfsplus/inode.c
> +++ b/fs/hfsplus/inode.c
> @@ -278,6 +278,11 @@ int hfsplus_getattr(struct user_namespace *mnt_userns, const struct path *path,
>         struct inode *inode = d_inode(path->dentry);
>         struct hfsplus_inode_info *hip = HFSPLUS_I(inode);
>
> +       if (request_mask & STATX_BTIME) {
> +               stat->result_mask |= STATX_BTIME;
> +               stat->btime = hfsp_mt2ut(hip->create_date);
> +       }
> +
>         if (inode->i_flags & S_APPEND)
>                 stat->attributes |= STATX_ATTR_APPEND;
>         if (inode->i_flags & S_IMMUTABLE)
> --
> 2.25.1
>