Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp824271pxv; Thu, 24 Jun 2021 22:17:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxy3h8yQz22SY5C9NwE8rgty39wf8048o33YE+qswNy8wtqq24+WF5cvyROaxYFcENfsjuh X-Received: by 2002:a6b:7d4b:: with SMTP id d11mr7104048ioq.161.1624598225712; Thu, 24 Jun 2021 22:17:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624598225; cv=none; d=google.com; s=arc-20160816; b=zNr6ZAEq4v8gzfhsu7lwtzPzhtYzvVTv50LxjQBIdcqS97vGqblAX+ngP8YtdtZTtQ 5an/NMq9Es23xTpcRa081KOPI1+7reH7sxPi5J5wQi62j/3ATKVHbSrGv13kXaZmAH3G G5eJ7yjub2DlVsZ8bG4ItIN9dOKVbz8x9U55XCQ6HR6sWnHKyjBAtyozZ3kdLdoLC22t s+OBwB5HJ19lvS50aXH2Y7jUGoPc5c1L+TeHMe+7MVWk23tn3SQC9/wy1gz/kiwQEc2X MIEjDzfPVvKXm47UtTGdl4WuSpbpH77gb9eRcf998rMUm+rS1TZrFtjrCkxiosVhzkGf jYkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :cc:to:subject:from:date; bh=j0wS242I9HZZx//+lbHW2+s4ScK7aX9RxSdhz3fgmPg=; b=YACP3m7x2mTe3655rD2tPTHFO4zBPXbSopA1VJbhhcYsmb6HYZoUk8omLBOiAfilHC 390NRIYn4YfQxPMa0JpZ2GZMOZw3BBe+xbQ3f5kXRkaUrwPfcC8a5aZNw22TuH4rwlKZ Tvo8eBB+vhbM4xavl5UU4rqo3uHkV1QbW5JUrSYasb0TeiygY2QQBRiqtFbMhJl4r7mH 5LGWwmVWJAeTj0ZY8VhoiWx71HMuDIEtIJ9/KTDl5PduEQ6y5q3th/U0rWAKPgLvNrDi juycthV1hr+pWEUceJWmjWMOBgmRG/f6P/7WMvCD2L19eYrnwdg2epS1uz7VVsRWaqCS JgpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y6si4820525ilq.94.2021.06.24.22.16.53; Thu, 24 Jun 2021 22:17:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233086AbhFYFSm (ORCPT + 99 others); Fri, 25 Jun 2021 01:18:42 -0400 Received: from mta-11-4.privateemail.com ([198.54.127.104]:4826 "EHLO MTA-11-4.privateemail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230139AbhFYFSl (ORCPT ); Fri, 25 Jun 2021 01:18:41 -0400 X-Greylist: delayed 124202 seconds by postgrey-1.27 at vger.kernel.org; Fri, 25 Jun 2021 01:18:41 EDT Received: from mta-11.privateemail.com (localhost [127.0.0.1]) by mta-11.privateemail.com (Postfix) with ESMTP id 60C3680094; Fri, 25 Jun 2021 01:16:21 -0400 (EDT) Received: from [192.168.0.46] (unknown [10.20.151.241]) by mta-11.privateemail.com (Postfix) with ESMTPA id B114C8008B; Fri, 25 Jun 2021 01:16:20 -0400 (EDT) Date: Fri, 25 Jun 2021 01:16:14 -0400 From: Hamza Mahfooz Subject: Re: Question regarding the TODO in virt/kvm/kvm_main.c:226 To: Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <2ZR8VQ.IJMS3PQLNFAS3@effective-light.com> In-Reply-To: References: X-Mailer: geary/40.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping On Tue, May 25 2021 at 07:45:53 AM -0400, Hamza Mahfooz wrote: > Would it be preferable to remove kvm_arch_vcpu_should_kick or > kvm_request_needs_ipi when merging them. I ask since, the last time I > checked, both functions are only used in kvm_main.c on Linus's tree. >