Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] serial: amba-pl011: add RS485 support
To:     Lino Sanfilippo <LinoSanfilippo@gmx.de>,
        Greg KH <gregkh@linuxfoundation.org>
Cc:     linux@armlinux.org.uk, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210618145153.1906-1-LinoSanfilippo@gmx.de>
 <YNSA1H0cFKiPUn6N@kroah.com> <5d7a4351-2adc-ea31-3290-91d91bd5a5d4@gmx.de>
From:   Jiri Slaby <jirislaby@kernel.org>
Message-ID: <db436292-4115-0755-57d8-d63986f84453@kernel.org>
Date:   Fri, 25 Jun 2021 08:01:36 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <5d7a4351-2adc-ea31-3290-91d91bd5a5d4@gmx.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 25. 06. 21, 2:15, Lino Sanfilippo wrote:
>>> +static int pl011_rs485_config(struct uart_port *port,
>>> +			      struct serial_rs485 *rs485)
>>> +{
>>> +	struct uart_amba_port *uap =
>>> +		container_of(port, struct uart_amba_port, port);
>>> +
>>> +	/* pick sane settings if the user hasn't */
>>> +	if (!!(rs485->flags & SER_RS485_RTS_ON_SEND) ==
>>
>> Why the !! in an if statement?
>>
>>> +	    !!(rs485->flags & SER_RS485_RTS_AFTER_SEND)) {
>>
>> Same here, why?
>>
> 
> This was copied from serial8250_em485_config(). But I think we can simply use
> 
> 	if (rs485->flags & SER_RS485_RTS_AFTER_SEND)
> 		rs485->flags &= ~SER_RS485_RTS_ON_SEND;
> 	else
> 		rs485->flags |= SER_RS485_RTS_ON_SEND;
> 
> instead. I will adjust the code accordingly.

This is different. You want to set ON_SEND when none is set. And unset 
AFTER_SEND when both are set. In your code, when both are set, you leave 
AFTER_SEND.

regards,
-- 
js
suse labs