Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp893152pxv; Fri, 25 Jun 2021 00:19:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyu1PD9QVPNNqseRUsyftSV7vdC7oT8cYbzv0jvAcTTgiSs/OHwDNd4xMVOVROdatqFyhNH X-Received: by 2002:a92:3302:: with SMTP id a2mr6403832ilf.62.1624605572416; Fri, 25 Jun 2021 00:19:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624605572; cv=none; d=google.com; s=arc-20160816; b=HbZAIp2FCpVv68ayEK0Xbdpo9uKmt3ebzzVwcUjZuENBR1ZDT5CEaPPA/JG1rH3Fvy uI85T8FHp6W6wBdyo5fBbelUk2UpwuqAKdFejelgMmTQE2ZLK/YhQ6vLsBS2LRBIjQMT GQ267LIGvFz531CBlYCAEJYhqtDob++W1v4fxkEEbT8q/BheifFSl0djXUBg4IrdgiDB +A7UQzg1qg8ZSX8mtT/gte42bB0/hkNzBHI6rNY0bMipDBOOuEbe/a/ABLITJi1vSYlQ 5D/INfLGn5m4f51yX+lLcc839BpbCxqUk0sk901VO933jqAU4Hpkt7JWnveUdJllCug2 pXeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=kYVlP09aoBeceP0zBI+4CfnkJXpyY9lE6UqEum6eaCg=; b=CNFBlVCufTmG5ZGm+6DiaBUGT5ZG4wc6NTG0OTo3wwkX78HWb1yg9k1ztrnJBv4+2O M0u6ByHCMry45OtSk8d182a6VNG6lxYrzikevEqHzBJ2g8uIOEQo/sIdCfGCRZJlJV/T FV+UijRWGg9F0YnDoMzrMYjOQjdAn6SvHi/A1rbHTUpwkmxXl9g1hoa0KFBIXx6mAy3s KtliiZT20WzaEM8A8nefljKoI7oQ770GjJVggLJpa4cBdHir04LWIOf7EjMC+Oio3Gac aXPg/gg63UWdKP6LwIhWuu414awcU2pV7xg5A3/A15944R32iiEEzqFF39CD8dhrjsul XhBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=BSXd2Frv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z14si5306214ilz.48.2021.06.25.00.19.20; Fri, 25 Jun 2021 00:19:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=BSXd2Frv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230037AbhFYHTv (ORCPT + 99 others); Fri, 25 Jun 2021 03:19:51 -0400 Received: from m12-16.163.com ([220.181.12.16]:44047 "EHLO m12-16.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229933AbhFYHTr (ORCPT ); Fri, 25 Jun 2021 03:19:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=kYVlP 09aoBeceP0zBI+4CfnkJXpyY9lE6UqEum6eaCg=; b=BSXd2FrvHmomZi5iq7MS5 zqynNNebY26bo7AfxBYl3nSt0mOS/834RgvWqh3ZWgOp04NgrfRPrXvfJAjOrXQt xPf80adVQ2WHmSAk588c0+lyl0KzyVrREGskgNgsFSFCi3ZIeGq8BL6AqczdIzHk uKIpf+VniGZRzjf6UYtDkI= Received: from ubuntu.localdomain (unknown [218.17.89.92]) by smtp12 (Coremail) with SMTP id EMCowAB3fb34gtVgrwaHzA--.35975S2; Fri, 25 Jun 2021 15:17:13 +0800 (CST) From: 13145886936@163.com To: dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, ira.weiny@intel.com Cc: nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, gushengxian Subject: [PATCH] ndtest: NULL check before some freeing functions is not needed Date: Fri, 25 Jun 2021 00:17:09 -0700 Message-Id: <20210625071709.22440-1-13145886936@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: EMCowAB3fb34gtVgrwaHzA--.35975S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7GrW7CFy5uFyftr43CrykKrg_yoW3Wrc_AF 42qr92kFW8JryxCa12yrn09FW8Ca15urs7W3yY9Fn3A34jy3y5Kw17Crn5GF1xWr98Ga9r tr95ArnxGr12kjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU5umh7UUUUU== X-Originating-IP: [218.17.89.92] X-CM-SenderInfo: 5zrdx5xxdq6xppld0qqrwthudrp/1tbiGhm8g1aD+PAGOgAAsd Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: gushengxian NULL check before some freeing functions is not needed. Signed-off-by: gushengxian --- tools/testing/nvdimm/test/ndtest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/nvdimm/test/ndtest.c b/tools/testing/nvdimm/test/ndtest.c index 6862915f1fb0..b1025c08ba92 100644 --- a/tools/testing/nvdimm/test/ndtest.c +++ b/tools/testing/nvdimm/test/ndtest.c @@ -487,8 +487,8 @@ static void *ndtest_alloc_resource(struct ndtest_priv *p, size_t size, buf_err: if (__dma && size >= DIMM_SIZE) gen_pool_free(ndtest_pool, __dma, size); - if (buf) - vfree(buf); + + vfree(buf); kfree(res); return NULL; -- 2.25.1