Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp933071pxv; Fri, 25 Jun 2021 01:27:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLu9kbDADZFYb73vrbfvjWk3y1+ilw+4NqSP+TrfypcVXEhX5VxOto8xSWDELpG+ywPkTj X-Received: by 2002:a92:b50d:: with SMTP id f13mr6652644ile.253.1624609660041; Fri, 25 Jun 2021 01:27:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624609660; cv=none; d=google.com; s=arc-20160816; b=hgaYw6wTGCRX/6IzmZFCeVXRDIkIuNUjtO079uQ+WsgRe8UFJDKATcpKX7hdAA2CxT pLr9LSiy8kzLguIvP/JyV7/QXSjsIasT1Q/ZrrKjohr4CzBD1y4AlKnL+G49QKLtP+FI J299x0EecrF0+ubMdgzAaN6snGd71ffbAKbX+4vgzIIqqvFH72B0uVMMh5mP+uABuy9I XSo8wa+cJ2Bpk5X4SJAhSVZaHSuHHi4bBLxvRWfqN7w+b8o288ZG7T9W4oHbpVJfVqSC gzbKRXIl3hyr/gRkEMJTcEvZlXsIs+3vkXdcItuofajKmAcUexO00zsjjy1h1gQGFJxT mVqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=PDbaX+iJgeQ8lHeB3U+F3+VCwu8kXy483wFD/xx+abM=; b=nY7O3snflVkr8iYQzltKLzGUcCYn+BZGF8IERx7nbEkt13Y7VXIQkDso92DseY7luW AAzIF3lk2kzAzuP4/7yz2OWKrX0nhvNW3JJpmbSRPZonliQUU4zjy7rcSlx8jAISKCiq LiU0ihiksBefp+Dos+4mfdXb7ZZFoJCnqctu4BMaXin/HG7bPaH9OzGkxWjKo8wql/rT fj/XEIkTdDUCNj2/IMF2bQQnzHMAHAV1elP1EcbHl8CjrYiIOY5NIv4KOwZnk3eRN8rW C8tgmSrTCY1D4bAlhvGmGhxa+GMlUoVI44hjTW7SEhLGyvRvi/5GQQRLErcIoKj+pf7w 60zw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w4si6442886iov.14.2021.06.25.01.27.26; Fri, 25 Jun 2021 01:27:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229940AbhFYI3S (ORCPT + 99 others); Fri, 25 Jun 2021 04:29:18 -0400 Received: from lucky1.263xmail.com ([211.157.147.130]:49898 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229764AbhFYI3R (ORCPT ); Fri, 25 Jun 2021 04:29:17 -0400 Received: from localhost (unknown [192.168.167.16]) by lucky1.263xmail.com (Postfix) with ESMTP id 1F07CD5B29; Fri, 25 Jun 2021 16:26:45 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 Received: from localhost.localdomain (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P12363T139709984536320S1624609601822117_; Fri, 25 Jun 2021 16:26:44 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: <978473b6890bd908bcaa94c0dbf5d258> X-RL-SENDER: jon.lin@rock-chips.com X-SENDER: jon.lin@rock-chips.com X-LOGIN-NAME: jon.lin@rock-chips.com X-FST-TO: linux-spi@vger.kernel.org X-RCPT-COUNT: 19 X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-System-Flag: 0 From: Jon Lin To: linux-spi@vger.kernel.org Cc: jon.lin@rock-chips.com, broonie@kernel.org, robh+dt@kernel.org, heiko@sntech.de, jbx6244@gmail.com, hjc@rock-chips.com, yifeng.zhao@rock-chips.com, sugar.zhang@rock-chips.com, linux-rockchip@lists.infradead.org, linux-mtd@lists.infradead.org, p.yadav@ti.com, macroalpha82@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org Subject: [RFC PATCH v9 00/10] Add Rockchip SFC(serial flash controller) support Date: Fri, 25 Jun 2021 16:26:29 +0800 Message-Id: <20210625082639.32688-1-jon.lin@rock-chips.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changes in v9: - Seperate DMA IRQ setting and wait_completion from DMA fifo transfer function to make dma_status_poll be possible(Which I will implement in u-boot) - Add SFC Kconfig detail comment - Seperate FDT binding docs and includes from rk3036 sfc_hclk patch - Seperate FDT binding docs and includes from rk3036 sfc_hclk patch Changes in v8: - Fix indent 4 to 2 in yaml Changes in v7: - Fix up the sclk_sfc parent error in rk3036 - Unify to "rockchip,sfc" compatible id because all the feature update will have a new IP version, so the driver is used for the SFC IP in all SoCs - Change to use node "sfc" to name the SFC pinctrl group - Add subnode reg property check - Add rockchip_sfc_adjust_op_size to workaround in CMD + DUMMY case - Limit max_iosize to 32KB Changes in v6: - Add support in device trees for rv1126(Declared in series 5 but not submitted) - Change to use "clk_sfc" "hclk_sfc" as clock lable, since it does not affect interpretation and has been widely used - Support sfc tx_dual, tx_quad(Declared in series 5 but not submitted) - Simplify the code, such as remove "rockchip_sfc_register_all"(Declared in series 5 but not submitted) - Support SFC ver4 ver5(Declared in series 5 but not submitted) - Add author Chris Morgan and Jon Lin to spi-rockchip-sfc.c - Change to use devm_spi_alloc_master and spi_unregister_master Changes in v5: - Add support in device trees for rv1126 - Support sfc tx_dual, tx_quad - Simplify the code, such as remove "rockchip_sfc_register_all" - Support SFC ver4 ver5 Changes in v4: - Changing patch back to an "RFC". An engineer from Rockchip reached out to me to let me know they are working on this patch for upstream, I am submitting this v4 for the community to see however I expect Jon Lin (jon.lin@rock-chips.com) will submit new patches soon and these are the ones we should pursue for mainlining. Jon's patch series should include support for more hardware than this series. - Clean up documentation more and ensure it is correct per make dt_binding_check. - Add support in device trees for rk3036, rk3308, and rv1108. - Add ahb clock (hclk_sfc) support for rk3036. - Change rockchip_sfc_wait_fifo_ready() to use a switch statement. - Change IRQ code to only mark IRQ as handled if it handles the specific IRQ (DMA transfer finish) it is supposed to handle. Changes in v3: - Changed the name of the clocks to sfc/ahb (from clk-sfc/clk-hsfc). - Changed the compatible string from rockchip,sfc to rockchip,rk3036-sfc. A quick glance at the datasheets suggests this driver should work for the PX30, RK180x, RK3036, RK312x, RK3308 and RV1108 SoCs, and possibly more. However, I am currently only able to test this on a PX30 (an RK3326). The technical reference manuals appear to list the same registers for each device. - Corrected devicetree documentation for formatting and to note these changes. - Replaced the maintainer with Heiko Stuebner and myself, as we will take ownership of this going forward. - Noted that the device (per the reference manual) supports 4 CS, but I am only able to test a single CS (CS 0). - Reordered patches to comply with upstream rules. Changes in v2: - Reimplemented driver using spi-mem subsystem. - Removed power management code as I couldn't get it working properly. - Added device tree bindings for Odroid Go Advance. Changes in v1: hanges made in this new series versus the v8 of the old series: - Added function to read spi-rx-bus-width from device tree, in the event that the SPI chip supports 4x mode but only has 2 pins wired (such as the Odroid Go Advance). - Changed device tree documentation from txt to yaml format. - Made "reset" message a dev_dbg from a dev_info. - Changed read and write fifo functions to remove redundant checks. - Changed the write and read from relaxed to non-relaxed when starting the DMA transfer or reading the DMA IRQ. - Changed from dma_coerce_mask_and_coherent to just dma_set_mask_and_coherent. - Changed name of get_if_type to rockchip_sfc_get_if_type. Chris Morgan (8): dt-bindings: rockchip-sfc: Bindings for Rockchip serial flash controller spi: rockchip-sfc: add rockchip serial flash controller arm64: dts: rockchip: Add SFC to PX30 clk: rockchip: add dt-binding for hclk_sfc on rk3036 arm: dts: rockchip: Add SFC to RK3036 arm: dts: rockchip: Add SFC to RV1108 arm64: dts: rockchip: Add SFC to RK3308 arm64: dts: rockchip: Enable SFC for Odroid Go Advance Jon Lin (2): clk: rockchip: rk3036: fix up the sclk_sfc parent error clk: rockchip: Add support for hclk_sfc on rk3036 .../devicetree/bindings/spi/rockchip-sfc.yaml | 88 +++ arch/arm/boot/dts/rk3036.dtsi | 42 ++ arch/arm/boot/dts/rv1108.dtsi | 37 + arch/arm64/boot/dts/rockchip/px30.dtsi | 38 + arch/arm64/boot/dts/rockchip/rk3308.dtsi | 37 + .../boot/dts/rockchip/rk3326-odroid-go2.dts | 16 + drivers/clk/rockchip/clk-rk3036.c | 5 +- drivers/spi/Kconfig | 12 + drivers/spi/Makefile | 1 + drivers/spi/spi-rockchip-sfc.c | 682 ++++++++++++++++++ include/dt-bindings/clock/rk3036-cru.h | 1 + 11 files changed, 957 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/spi/rockchip-sfc.yaml create mode 100644 drivers/spi/spi-rockchip-sfc.c -- 2.17.1