Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp940428pxv; Fri, 25 Jun 2021 01:40:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKTxlOoaj4MyFfOCKvp6EWWxV4gtYuO/uAO70/NcRwrRCIaQe0xfKmh69N4rwDkoopiOMM X-Received: by 2002:a92:da52:: with SMTP id p18mr6627348ilq.7.1624610432395; Fri, 25 Jun 2021 01:40:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624610432; cv=none; d=google.com; s=arc-20160816; b=EjO2uBMgEzfIzaGi3wrzEA1bzx58rJm7RU75Umxlq4Edl/q1Yggp0e1FY5nL8XAvn6 5YU5sESRUirrAmWIfGZi9VY+zsrGPqWEVR7F9p+/gQIozpBN/vAlW8YrUYoyYcJq5sgo oWLL6gYpkhcdTkYoaShIwCnr81pBDyeUxzCj86AtUeDBwyB/ZiWf7JlfUb/eopJPPJ4n Fmi7yaWk7FvV2owgp5jMzqcKw8yh50AzaW9niIhctOc047ZDiUMRg7zVTsoInmm05pBb 2WEtSrFWj6766d/D7ii+m+GKmdSzq70LgqUv9S29EEPLtcWQVJoOcA9KRQhpgvcCIfuw CpUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:references :mail-followup-to:message-id:subject:cc:to:from:date; bh=qSllXdDBV+8236PmL28m2DJrYBF/0DTF95xJIQEXoRo=; b=xOnu3mJLZu2czToPPxMPUW+1nvnA4cUSiEaoZcio3QY2II5xTrmSZxST7P9y2LBJTc mgE94RpJvLS2zodWDbrdh5EV27yugARjZgS7Ve9VbUBC46OzJtREgtArrWHMUJCehkRH PIHvCXcA0GzMelMZVW+XgQ6Q4P6eEYpTmyyfY69zfnE5Xgj879M7odzBtKFV1IAOC0wV 5MXBvPa70VWBZ+5QhPzKZ5m6Rp+lmjQDNdVq+90CE2gTq3lr1ufjFztbmTkHJBQ/c8Ws 4M3zN1N8Gd5l05L90YWoUbfOjKHVnHmpbz5Hao6Y+bOzZ8jsm1qm4V+Xn4NL7w7Bvndi cdWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f17si5277095ilj.76.2021.06.25.01.40.20; Fri, 25 Jun 2021 01:40:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbhFYImG (ORCPT + 99 others); Fri, 25 Jun 2021 04:42:06 -0400 Received: from mail.thorsis.com ([92.198.35.195]:44139 "EHLO mail.thorsis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229902AbhFYImF (ORCPT ); Fri, 25 Jun 2021 04:42:05 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.thorsis.com (Postfix) with ESMTP id C61C23593; Fri, 25 Jun 2021 10:39:43 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.thorsis.com Received: from mail.thorsis.com ([127.0.0.1]) by localhost (mail.thorsis.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1foNQkjRn8tw; Fri, 25 Jun 2021 10:39:43 +0200 (CEST) Received: by mail.thorsis.com (Postfix, from userid 109) id 4118435C5; Fri, 25 Jun 2021 10:39:42 +0200 (CEST) X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RECEIVED, NO_RELAYS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.0 NO_RELAYS Informational: message was not relayed via SMTP * -0.0 NO_RECEIVED Informational: message has no Received headers Date: Fri, 25 Jun 2021 10:39:32 +0200 From: Alexander Dahl To: Bjorn Andersson Cc: Marek Behun , Pavel Machek , Rob Herring , Andy Gross , Thierry Reding , Uwe Kleine-K?nig , Lee Jones , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org, Marijn Suijten , Yassine Oudjana , Luca Weiss , Subbaraman Narayanamurthy Subject: Re: [PATCH v9 1/2] dt-bindings: leds: Add Qualcomm Light Pulse Generator binding Message-ID: Mail-Followup-To: Bjorn Andersson , Marek Behun , Pavel Machek , Rob Herring , Andy Gross , Thierry Reding , Uwe Kleine-K?nig , Lee Jones , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org, Marijn Suijten , Yassine Oudjana , Luca Weiss , Subbaraman Narayanamurthy References: <20210623035039.772660-1-bjorn.andersson@linaro.org> <20210625011932.6354e397@thinkpad> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Bjorn, Am Thu, Jun 24, 2021 at 06:44:54PM -0500 schrieb Bjorn Andersson: > On Thu 24 Jun 18:19 CDT 2021, Marek Behun wrote: > > please don't use in new bindings in examples. > > Instead use color, function and function-enumerator, i.e. > > > > color = ; > > function = LED_FUNCTION_xxx; > > function-enumerator = ; > > > > Can you point me to something helping me regarding what "function" to > use? > > For this particular devboard that the example comes from I have 4 LEDs > that are named "user1", "user2", "user3" and "user4" in the board > documentation. I can make up whatever for the example, but I would like > to get the following dts additions follow the expected guidelines. I asked myself the same question in the past. The wohle list is in 'include/dt-bindings/leds/common.h' and I in my personal project I opted for LED_FUNCTION_INDICATOR, but yes, the confusion is real. Greets Alex