Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp969597pxv; Fri, 25 Jun 2021 02:29:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJRGWu8yGY2HN8ECc4v+NGGKnuvEUyZp6V1L8eFoITFJ454M6wl0+9G6nmhUCCNx1gvH1E X-Received: by 2002:a05:6402:4393:: with SMTP id o19mr13145748edc.263.1624613383293; Fri, 25 Jun 2021 02:29:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624613383; cv=none; d=google.com; s=arc-20160816; b=Lj0k5psVC9Bkb/gc/gTAgZNklkbMllR4fSX1ThNTpHo4EXB6QKqgehriaFaVSEQiFH rHJWhgbZ5zk8TS5SfpTCQz0gE5SlD/EV9iMZgMEKT5+1lXWYH6baNwwSYFrR79OuOz6j aXhYY2ntN1IewyPrn3flCL7wCERJwezkbyLMsVxqi0SIC5ASbAwhqq0IgC1clc18TEAv RhfAl9QQTY4zat8LTLWGe0P+i/ygW9DT06Gt7o3Cm0H0Ns+mDh4ApRaYSINfOfypqspZ +h2TbEUBDvgevgGmOMMkz7q+7RicidATMGpHv9M4vIrEGvCClXrQ70zCN4kxSWkhIcEW 6uCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SjGReaSfzObkIWIE+f3KhQydIkcR4mgV8ncU1I+OXTA=; b=vWjd1PMp48d2XlRbtWmLiPvK9MezV3o9TXuTwrYFdafSPs1q32cKlG+33c3e7r2zgM 1xHlq0A6YYaZL5Nbm/CvQzhJ0hSLoEhYDtriyEz/mkYElXBMeWLr7UF0Z4KISZxSAfrJ +2x7txGD30+2KoMwTRxRJP+Gw6jsoz526g2dQFYg0S6+mcG5+nmcDuKaaen1grV9wnqv rKOB+t/FVwDiF2g7KE5nc3tf+RdnrEQRYUGGOBJIuSwSC5jL3jF3r7E9bciLB/rR5end eeVfdPjHqurpK58tA6qW95hJqSNpOeRaGScZaCCOBJTziPc2soZKjL4/icgTV+yKH2Ez jsag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=lzUYzwAI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u9si5811902eds.493.2021.06.25.02.29.19; Fri, 25 Jun 2021 02:29:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=lzUYzwAI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230461AbhFYJaY (ORCPT + 99 others); Fri, 25 Jun 2021 05:30:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230020AbhFYJaY (ORCPT ); Fri, 25 Jun 2021 05:30:24 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6B36C061574; Fri, 25 Jun 2021 02:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SjGReaSfzObkIWIE+f3KhQydIkcR4mgV8ncU1I+OXTA=; b=lzUYzwAIFt/4HG1YZ4dIeB4K6f bWX04mCHTlBWwpaRSo9a2Nnqh5y/qkumSHRObxoczpC1ed73q9SASR1ThuyVochZ5MsTuijoHVVvi LYak5+l4irUfbxbaOX1vaJkc4ds5eGOhlqWpU9E6GjKDgNYediiXfCYyt1xyJIIVJndOaBErHnIaH S2BdR6xNvEuf8lzapqysvw6gYRt86p9EZlNJSX2jyOZ53fIBEchfwCjFTpb584I/vqog7VwKefiET z95aKo/tOshe+cp0HVj5FHwSLeXcKtVgPi7+TOPi9sj1qV/EwydrZrJVdDW9AqUqSfIIGxOlwlZtk 8Mwy7W6Q==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwi7R-00BWrn-Cj; Fri, 25 Jun 2021 09:27:32 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 5F8BA300233; Fri, 25 Jun 2021 11:27:31 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 3FFA6200B392D; Fri, 25 Jun 2021 11:27:31 +0200 (CEST) Date: Fri, 25 Jun 2021 11:27:31 +0200 From: Peter Zijlstra To: Daniel Bristot de Oliveira Cc: Steven Rostedt , Phil Auld , Sebastian Andrzej Siewior , Kate Carcia , Jonathan Corbet , Ingo Molnar , Thomas Gleixner , Alexandre Chartre , Clark Willaims , John Kacur , Juri Lelli , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V5 12/14] trace: Protect tr->tracing_cpumask with get/put_online_cpus Message-ID: References: <38d2ef13b33c42fcf424a6213a27c8b5246548e0.1624372313.git.bristot@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38d2ef13b33c42fcf424a6213a27c8b5246548e0.1624372313.git.bristot@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 22, 2021 at 04:42:30PM +0200, Daniel Bristot de Oliveira wrote: > + get_online_cpus(); > cpumask_copy(tr->tracing_cpumask, tracing_cpumask_new); > + put_online_cpus(); I'm aware this patch will go the way of the Dodo; but for future reference, these should be spelled: cpus_read_{,un}lock(). The old names are still around, but I suppose we should do a cleanup of that some day.