Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1006276pxv; Fri, 25 Jun 2021 03:24:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEmjetk6Rk7WF3KORhugfIDA/Sa22IC48bTDlOMZCvDz3vbaolg3xbYqLlONGygyZSCtlk X-Received: by 2002:a05:6402:5143:: with SMTP id n3mr13529213edd.80.1624616696024; Fri, 25 Jun 2021 03:24:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624616696; cv=none; d=google.com; s=arc-20160816; b=sJt7BSpJlpt9el5/8Sf2zcVJXEJH+8WsrtYW0NrQjkgCs8sTlRJ2YDYJ7KMPRImuDT VlnyaeR5aSelW4ybhcQUw+5iZ4n93ufW4dyCzwTqnIYgjpw+5IRvKZcDRcKdGimrcjvf T9Yr1Ul7Bh5asKTB6SYwkYs+NAtNOX2+Vzi3+8ngY0CPhKEZgGrMbAJt+fj2xPqtsLC2 CYhEbgfveALuuZoe6r1xTRxEnKhgyPVcoWvOeb8esAoCLiPQ6JF2pqboenIKTmOdbNTc rj5GuTDqNt73Bu8vvlf1BXjRw8acn48OpaNg58Wmzbyhj2dgFrsLpjrWe6wNN58KmYPe krhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=BKrfehGtS1QMrtSpZxjNjNx4qrfWv7qQYNoqZBz7dgw=; b=NhpNWeTTX/uNz05bRRF+VnxO5KYDxVUda9zpArHgk38SuHOYZkHyBgjcCksgZp8g06 Fu933ltxe2q3Z8KTA4M8M4lUNNwIKQmdzwQdFMOPrztdOwzwoT9C+a/WYvVOO8D1vxNl sVebVe10iqtidVdqyKsgrO7dhPrqmhjuHPN8hMfBvc8Xw2ICBKyAxOJZUJsQSOwRVU6y 3puQhxcSrChgm5Wk11/+/+ShUDXYAR3Jw73/FJkPLfe9Cu9sWxetPf6rw+bmTB9g9EOL 2ZPynI0Ck46Qnjh2w2N5oHZc1P5QctQJ6z+U6wITZycCcMc2k3yMK9sXTDl/qAEKPIEI 26SQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p16si5947071edq.404.2021.06.25.03.24.32; Fri, 25 Jun 2021 03:24:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231453AbhFYKXl (ORCPT + 99 others); Fri, 25 Jun 2021 06:23:41 -0400 Received: from mail.netfilter.org ([217.70.188.207]:51340 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231182AbhFYKXi (ORCPT ); Fri, 25 Jun 2021 06:23:38 -0400 Received: from netfilter.org (unknown [90.77.255.23]) by mail.netfilter.org (Postfix) with ESMTPSA id 7E1FF607EB; Fri, 25 Jun 2021 12:21:15 +0200 (CEST) Date: Fri, 25 Jun 2021 12:21:13 +0200 From: Pablo Neira Ayuso To: Walter Harms Cc: Colin King , Jozsef Kadlecsik , Florian Westphal , "David S . Miller" , Jakub Kicinski , "netfilter-devel@vger.kernel.org" , "coreteam@netfilter.org" , "netdev@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH][next] netfilter: nf_tables: Fix dereference of null pointer flow Message-ID: <20210625102113.GB32352@salvia> References: <20210624195718.170796-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 25, 2021 at 10:06:26AM +0000, Walter Harms wrote: > hi Colin, > most free_something_functions accept NULL > these days, perhaps it would be more efficient > to add a check in nft_flow_rule_destroy(). > There is a chance that this will catch the same > mistake in future also. I'm fine with Colin patch. Thanks.