Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: x8tVQ55SwbdSwPl2aCpLthoXwOyvWQBnMaRy/MxE1B/owIon5sG7+/q8DqRw/8WmC2WCubB01P
 Vrv33MWlcPjg==
IronPort-SDR: dPfPo6GYQkxkecwpT1I+fRhs3VVyqD6TTNKZhpm7JmpiNcbRKTHdcA17ZQlfbFeDG0qprXoj3Y
 793jmGben/Gg==
Date:   Fri, 25 Jun 2021 19:23:14 +0800
From:   Yu Zhang <yu.c.zhang@linux.intel.com>
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Maxim Levitsky <mlevitsk@redhat.com>
Subject: Re: [PATCH 05/54] Revert "KVM: x86/mmu: Drop
 kvm_mmu_extended_role.cr4_la57 hack"
Message-ID: <20210625112314.nn6llnk7dtovjg4e@linux.intel.com>
References: <20210622175739.3610207-1-seanjc@google.com>
 <20210622175739.3610207-6-seanjc@google.com>
 <20210625084644.ort4oojvd27oy4ca@linux.intel.com>
 <09a49caf-6ff5-295b-d1ab-023549f6a23b@redhat.com>
 <20210625092902.o4kqx67zvvbudggh@linux.intel.com>
 <885018ab-206b-35c7-a75a-e4fccb663fc3@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <885018ab-206b-35c7-a75a-e4fccb663fc3@redhat.com>
User-Agent: NeoMutt/20171215
Precedence: bulk

On Fri, Jun 25, 2021 at 12:25:46PM +0200, Paolo Bonzini wrote:
> On 25/06/21 11:29, Yu Zhang wrote:
> > Thanks, Paolo.
> > 
> > Do you mean the L1 can modify its paging mode by setting HOST_CR3 as root of
> > a PML5 table in VMCS12 and HOST_CR4 with LA57 flipped in VMCS12, causing the
> > GUEST_CR3/4 being changed in VMCS01, and eventually updating the CR3/4 when
> > L0 is injecting a VM Exit from L2?
> 
> Yes, you can even do that without a "full" vmentry by setting invalid guest
> state in vmcs12. :)

Hah.. Interesting. :) I think this is what load_vmcs12_host_state() does. Anyway,
thanks a lot for the explanation!

Also my reviewed-by for this one.

Rviewed-by: Yu Zhang <yu.c.zhang@linux.intel.com>

B.R.
Yu