Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] certs: Redirect openssl error message to null device
To:     Stefan Berger <stefanb@linux.vnet.ibm.com>,
        keyrings@vger.kernel.org, jarkko@kernel.org
Cc:     linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org, zohar@linux.ibm.com,
        nayna@linux.ibm.com, jeyu@kernel.org, dhowells@redhat.com,
        dwmw2@infradead.org, kernel test robot <lkp@intel.com>
References: <20210625122902.4058783-1-stefanb@linux.vnet.ibm.com>
From:   Stefan Berger <stefanb@linux.ibm.com>
Message-ID: <9e925935-529e-49c9-e499-3eac43bddb66@linux.ibm.com>
Date:   Fri, 25 Jun 2021 08:32:37 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20210625122902.4058783-1-stefanb@linux.vnet.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

On 6/25/21 8:29 AM, Stefan Berger wrote:

> From: Stefan Berger <stefanb@linux.ibm.com>
>
> Address the following issue detected by the kernel test robot when
> there's no certificate file at the time when checking for the type
> of key in the cert:
>
> Can't open certs/signing_key.pem for reading, No such file or directory
>
> The simplest solution is to redirect openssl's stderr output to /dev/null.
>
> Fixes: 28d62d945ded ("certs: Trigger creation of RSA module signing key if it's not an RSA key")
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> Reported-by: kernel test robot <lkp@intel.com>


Jarkko,

can you please squash this patch into the one it fixes. Unfortunately 
when rebasing you will have to fix the subsequent patch from this merge 
error

ifeq ($(openssl_available),yes)
<<<<<<< HEAD
X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text 
2>/dev/null)
=======
X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text)
endif
 >>>>>>> 87e968848116 (certs: Add support for using elliptic curve keys 
for signing modules)

to this:


ifeq ($(openssl_available),yes)
X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text 
2>/dev/null)
endif

Thanks.

    Stefan