Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1122824pxv; Fri, 25 Jun 2021 06:04:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMmrs/QWSug88QAWHaNn/P+9xS4JmFu7e95zecYfJg++TbLAjGPAhsBWyKZTHubsCMreSK X-Received: by 2002:a17:906:4f14:: with SMTP id t20mr10619191eju.398.1624626254053; Fri, 25 Jun 2021 06:04:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624626254; cv=none; d=google.com; s=arc-20160816; b=aV35+csyKWJxbgB7iA1tukDLnrK2LwxNIiYZM4n0rnVDvl9E1TDOxgpxkKl41Qb/TM 43BDEqPjqeZD3ycYsNgu8wv5rnw0cuUVF/IrCSCVCTLHvr7/f2hsoCops94Lk5gGwwwC /i9TU0TFCoHavKaTvfgV++9yRV6yv3FvSYJy/whTH2WDC4tFd5al0BnpOgqFEpbJKpHZ r06PDryEJVOZURqA/OB4GYIHhlPlKf3qOkkrpjXBtIQ4q1tsNcG5L+VfnR2zbG4mF4W4 Pl0qIyreUKkm/+NoSq7uZ7dTknb1QaVcjsVbQ/4YSEJRQSIE+HC7ZFAv1jJWCL32q4jE 3ZEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Ir2eWPk3ec0Cg8tDR/RjzUrlOF71WYHqtK3vtayAp3E=; b=XnQ2EZaoWSf2LBMB4PhqBFeMSzDbIkc8j/T2kKbuyi9CifNpsZyHSiMCwSp0N1YoXi t5cxAmwYLynqYVaSrBn1LpNynMCr7f8x9myU7IGFpb/GHyimFJhRr2Qv5KBLkMN4xKlg /t142wD3RAQ6s+gFGLi9YRRPUt9XhUv1PIRcV2lHBuSS7ycNOMyygGzclk6W84LD+3OI poSCbpb5Fkehy5dEh2bEZRF9PCkGl+CJe8go9F5HyMP8vAaiRu81FgnF/1djPAUnSNaL S6AcXtXikv9yxWYiLPpnVoNJdj3fnlVkdS3hIYvk7lUlGfkr39sHtv/r6oBTTeX2Yper D9gg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v6si5001058edc.553.2021.06.25.06.03.43; Fri, 25 Jun 2021 06:04:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231952AbhFYNCN (ORCPT + 99 others); Fri, 25 Jun 2021 09:02:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231680AbhFYNBm (ORCPT ); Fri, 25 Jun 2021 09:01:42 -0400 Received: from xavier.telenet-ops.be (xavier.telenet-ops.be [IPv6:2a02:1800:120:4::f00:14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E70E7C061141 for ; Fri, 25 Jun 2021 05:59:17 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed20:1476:ce84:e216:add8]) by xavier.telenet-ops.be with bizsmtp id MQzC2500R2B1U9901QzCdo; Fri, 25 Jun 2021 14:59:14 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lwlQO-003TMN-Ao; Fri, 25 Jun 2021 14:59:12 +0200 Received: from geert by rox.of.borg with local (Exim 4.93) (envelope-from ) id 1lwlQN-004sR8-My; Fri, 25 Jun 2021 14:59:11 +0200 From: Geert Uytterhoeven To: Robin van der Gracht , Rob Herring , Miguel Ojeda , Paul Burton , Greg Kroah-Hartman , Pavel Machek Cc: devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH v2 11/18] auxdisplay: ht16k33: Remove unneeded error check in keypad probe() Date: Fri, 25 Jun 2021 14:58:55 +0200 Message-Id: <20210625125902.1162428-12-geert@linux-m68k.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210625125902.1162428-1-geert@linux-m68k.org> References: <20210625125902.1162428-1-geert@linux-m68k.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no need to check the return code of input_register_device(), just propagate it to the caller. Signed-off-by: Geert Uytterhoeven Acked-by: Robin van der Gracht --- v2: - Add Acked-by. --- drivers/auxdisplay/ht16k33.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c index 99daf1974980b435..8c9acc4800bc94e0 100644 --- a/drivers/auxdisplay/ht16k33.c +++ b/drivers/auxdisplay/ht16k33.c @@ -378,11 +378,7 @@ static int ht16k33_keypad_probe(struct i2c_client *client, ht16k33_keypad_stop(keypad->dev); - err = input_register_device(keypad->dev); - if (err) - return err; - - return 0; + return input_register_device(keypad->dev); } static int ht16k33_probe(struct i2c_client *client, -- 2.25.1