Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CAADnVQJux+8n-vpuK9FqTLuj4cXrp04pGkpvKaUdAPXLQ4c-PQ@mail.gmail.com>
 <20210622110026.1157847-1-ravi.bangoria@linux.ibm.com> <CAADnVQKLwEEZJ=_=g8RfgOrt9b1XN=dM9bt515pOrru=ADQR1Q@mail.gmail.com>
 <960b5e26-e97d-2b1a-4628-df8525c0728b@linux.ibm.com>
In-Reply-To: <960b5e26-e97d-2b1a-4628-df8525c0728b@linux.ibm.com>
From:   Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date:   Fri, 25 Jun 2021 08:07:11 -0700
Message-ID: <CAADnVQL7BdReSgw++Eh+MvS4+_uqnFFvp+7N4cGO2MWMTWaqcQ@mail.gmail.com>
Subject: Re: [PATCH] x86 bpf: Fix extable offset calculation
To:     Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        David Ahern <dsahern@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        X86 ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Network Development <netdev@vger.kernel.org>,
        bpf <bpf@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jun 24, 2021 at 11:22 PM Ravi Bangoria
<ravi.bangoria@linux.ibm.com> wrote:
> > Could you send a followup patch with a selftest, so I don't make
> > the same mistake again ? ;)
>
> Unfortunately extable gets involved only for bad kernel pointers and
> ideally there should not be any bad pointer in kernel. So there is no
> easy way to create a proper selftest for this.

Right. We have lib/test_bpf.c kernel module for such cases.