Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1256379pxv; Fri, 25 Jun 2021 08:46:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwktsPkB6nIrN8TiCaKVRw8qlyuqjPBY4CDjr3JSvSq5gxfBMTWFLrfAp53p1oslohFiLRA X-Received: by 2002:a05:6402:1355:: with SMTP id y21mr15736695edw.136.1624635964418; Fri, 25 Jun 2021 08:46:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624635964; cv=none; d=google.com; s=arc-20160816; b=LcITR+1+t5MyZcDSos2ataJwW5z+LVmsOmRlSdjeg+J5r6OwQ4D8qR8IBIkcK56nK5 OmpFI54feYUIIx5j8bRsRud3FPulhII+wgf4o1KNSxxy2mOacijcXotoAFqiBa7M5H7d cHgDG22Ihd+hmtBuBB9/zm+PUSFjIYVeqJlM9xatmSk+26tFtY/4ujHYT9z8QElKcZPr cXaKwstbEkvaPRiA44bWrBTXtY5XW/LwmpC1lPhfGMEeZRtkXBEVq2kiuWOzRBruiuDe mk3aVzvRFnC4g8Orzps2a/jiqpKd2JNCVzpRx4siby511w0u6+ieZzgSi8lETAS8yYPa YRYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:ironport-sdr:ironport-sdr; bh=BxBFNEdIDRqoHeY5lZUSNAZm9Np2xFGwg0GtxAq6atM=; b=TVLDb8IuuPcfzOLmrdnoAzeNwBetySLD7+SwXTVbzgLWUmj25rwCygDRNHNuQ/qJFe NdOC+n9T4XXSOJvUxepfYo1yZgQUZcoO8bUaIOm3vbuFnpnTc0PrzHZwqKmeLYdfM9tV 71rf6YzYOu70gCofvKzOR3yYjdCCaGt1kfpJw5seHQJcJF2Y6u8flb3fP4Y/HmZfEVpj Ok9KH7c0lUOPRf4hM6nuz/fFatv/tjq4KEpiMyLHeyC3FAxlTzN48Xp5LX75Eg2teJhE ErHNmnCsLAvu6rEqManO2uIsokxN61kIzL8n7/dx95kdM8GP/Wq3BSCmQqZ1cYFz6N8M SWNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l2si6555257edv.432.2021.06.25.08.45.40; Fri, 25 Jun 2021 08:46:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229944AbhFYPqc (ORCPT + 99 others); Fri, 25 Jun 2021 11:46:32 -0400 Received: from mga01.intel.com ([192.55.52.88]:62970 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbhFYPqb (ORCPT ); Fri, 25 Jun 2021 11:46:31 -0400 IronPort-SDR: Lps/CfaG0jrd6eQIFEoZJLK3akLn2Nv5+ZHY81DihrSrqtzNnTzv5RwXHvTuAhYw3WO0YyJz+2 ZBcCcKvxtsnA== X-IronPort-AV: E=McAfee;i="6200,9189,10026"; a="229289098" X-IronPort-AV: E=Sophos;i="5.83,299,1616482800"; d="scan'208";a="229289098" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2021 08:44:10 -0700 IronPort-SDR: 5bPanxU12mvPDvTlogfFG4dT8fLYFZ/4BLxZD6jKIRYjohTxacPTaNXDYBN7cLfG4BblN1XeSg aLAdvnmOh4QA== X-IronPort-AV: E=Sophos;i="5.83,299,1616482800"; d="scan'208";a="488228748" Received: from akleen-mobl1.amr.corp.intel.com (HELO [10.209.62.195]) ([10.209.62.195]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2021 08:44:10 -0700 Subject: Re: [PATCH 2/7] perf: Create a symlink for a PMU To: "Liang, Kan" , Greg KH Cc: peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org, eranian@google.com, namhyung@kernel.org, acme@kernel.org, jolsa@redhat.com References: <1624497729-158864-1-git-send-email-kan.liang@linux.intel.com> <1624497729-158864-3-git-send-email-kan.liang@linux.intel.com> <1e536604-cf93-0f09-401e-2073924c5582@linux.intel.com> <29d5f315-578f-103c-9523-ae890e29c7e7@linux.intel.com> <540d8a38-da12-56c8-8306-8d3d61ae1d6b@linux.intel.com> From: Andi Kleen Message-ID: <6f2941a4-4a32-ea09-bbc6-5a8e4836411b@linux.intel.com> Date: Fri, 25 Jun 2021 08:44:09 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > We have an attribute "caps/pmu_name" for the core PMU. Maybe we should > add it for uncore PMU as well. For example, > > $ cat /sys/devices/uncore_type_0_0/caps/pmu_name > cha_0 > > Userspace tool can get clues about what type_0_0 is. It would break all the old tools, but I suppose it could work for updated tools. It isn't only perf that is parsing this, but some other libraries too. They all would need to be updated too. I think I still prefer the symlink. It would just work and keep full compatibility. But yes maybe there is no choice. -Andi