Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/1] RDMA/cma: Fix rdma_resolve_route memory leak
To:     Jason Gunthorpe <jgg@nvidia.com>
Cc:     linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        Doug Ledford <dledford@redhat.com>
References: <f6662b7b-bdb7-2706-1e12-47c61d3474b6@oracle.com>
 <20210625150311.GA3006866@nvidia.com>
From:   Gerd Rausch <gerd.rausch@oracle.com>
Message-ID: <dabc6d03-da37-27df-833c-1851d08706e0@oracle.com>
Date:   Fri, 25 Jun 2021 09:27:54 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.1
In-Reply-To: <20210625150311.GA3006866@nvidia.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ib0.gerd.us.oracle.com (2405:ba00:8000:1021::1046) by SA0PR11CA0059.namprd11.prod.outlook.com (2603:10b6:806:d0::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Fri, 25 Jun 2021 16:27:58 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 98380a80-8475-42bd-d4a0-08d937f63277
X-MS-TrafficTypeDiagnostic: BYAPR10MB3494:
X-Microsoft-Antispam-PRVS: <BYAPR10MB3494AF594ED683FF74682FF687069@BYAPR10MB3494.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 36jBLi9oY5mHP2tXelnzScUU3NQ6u7gDem4rRNufvOFY0yRv181DPUSh3X5E0bidhDMpUsVHh7LlUIzbQIQeNp2+O+WfIBDSJIcwvpsr89sbBgnof859c9wW6gc0HLWIPQTsOCT1HIipIGgl+WGILUlOt/igy6Y/B0z3Lt2ucrAfPuVMPGUDU91UQxJfFDnLlqv838QMwfdlci3laIVmYBa3P3xjwbRXsoFHzD2kQVlTMGcbj8sdNMsA5GJSll3iTz0ZfpfMk5ToT1iMLBTt5BG1bmbHLlXM3ighmE+rfBSq0OZb1m7wjzKrs1PC216ln+tZ/LE7YPzFktsolxaYb2DV+6QcC0oz87Kjf3ovyD3IApHYG8rJdThM2+IIAaQpod6zTUoDFPjvNSitTSESR6DhFJPUT5J0wiJylrAUoy5GOmP7Qu1/zM/ZR9rEEcehuBBxguTSDrv9Dn+hc3iUqUuYxydOvYKT9yS9xh9eTQX6o3uEONpO0cG8pSC89UqB3npZTWEsyLATTarOu2CEMfiFSiayoBE3x3c6ywT9Y82ILtI0b6HtcZs5XHXUWiKu2g7VmqOCX+DHH6Q/zWoD0MkwYjZZ/9DrDplxA3rop+XrfC7hC/C9fUJPhxBDEbH3R8EyulT7rE8rBHNS7QBG82FuT14gj69+bVcD/JdpMafwFTYZt0A8pAUb0RUqKOwfBvhNXVHnRNraSccn0xxM+05E5oW/hk7mb3uOB7xhbrYFBOPQd+05KOSXbEX2LLXp
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(346002)(39860400002)(366004)(376002)(136003)(8676002)(31686004)(6916009)(52116002)(66556008)(478600001)(66476007)(6666004)(7696005)(16526019)(66946007)(5660300002)(6486002)(4744005)(316002)(186003)(83380400001)(4326008)(36756003)(2906002)(2616005)(31696002)(38100700002)(8936002)(86362001)(44832011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2Myd3dzZnVybFBFYUZaeTVqYjh3VFBvRTBVMFhza1ZzQVBmMDRidDJNdFph?=
 =?utf-8?B?cytTbU1vN2g3UG16U21pd0V3QnpMQ2hJeC9wRTl4ajlqanlTZ0w5bHBRZVpG?=
 =?utf-8?B?TEplR0w5ZlZVOEdSdGF4eHRTOC92NysvUzhhM0FuZC9yL243VS9mQTlWM0Zi?=
 =?utf-8?B?QjRMdFIrTy84MUt6eXVVTUdJWXNWbVRBRGs2a1FzVXg1cHdWeGZJNGFGdmhX?=
 =?utf-8?B?OUlMU3VpVDlCQzFGL3VGU2ExdXJoRXVmdkNtc3N1N1hCd3hZb2FQK29YaGZT?=
 =?utf-8?B?M1FNdEZ1RTkrN1c2akdHcURweG45TDhqL1FGdVFZQnh0bXo0VE9wYlhHV0Iy?=
 =?utf-8?B?ZHFvMWF4MHJUM3Q5L3lHVWJ0L2gwZHZLU3B4UDBpS01iZHZicWFHMnZPT0l1?=
 =?utf-8?B?UmxhU1JiK1Y0RFBJR0hRbzdpaEtKUURiR1B0amxQK3VuTzd2a3FzVXV3Y2VR?=
 =?utf-8?B?YUxLUk1IZGdvYjNoMjU2VmV5OG5rTFVzdDdOWU45SUhES3ZLbUtPeXU2aDNo?=
 =?utf-8?B?c3FTZTdEQzhQR3BDWHVGYmJ0aVMzMWtiRStHSUpNa0Rtc2tJTjhFR1BMNStL?=
 =?utf-8?B?MndLeHRtZGlmMGxCWFZmUXZPTE5LT2lOUnhib2lta296QkllZnovNWpvUVJM?=
 =?utf-8?B?UGc5SW0xSk5uM0xWV0FwOWZJcFhYQ2pjdkkrL0dpVWNBOVJvVGtyQk9MRnlq?=
 =?utf-8?B?QXhVaWtzcGg5eWpDdjRocjg5OHNzM1hkeTNoMnFLQll2M2VpaVFJSSt1a20w?=
 =?utf-8?B?VG54MFk5ZE82NWFGQk9sTHRnU2JxcHM5bldKK0N3RXl2WUZNakl1Rzh3elAv?=
 =?utf-8?B?ZUpSRExHUjkzV09sSit2bzlNQmZKUTJiNitqbE8rcVN5SkpjTFRmYW9rQWhs?=
 =?utf-8?B?Y2hBVXZnTS9SanduQngraHJCNElQWmNlNER1MVpvK3JlcllNd3JnMkN1WUZl?=
 =?utf-8?B?YVEzOWdpSUNvVXJnOTlDVktmK1dJa3NLbFpEVmE3Qlp6dEpYTHV4cTd5SDZo?=
 =?utf-8?B?SGFxdFQwOUUxZzcralJISkpPeGFQZ0Jmbm0yV2l4TEZIckpFaFRyQzgzTkFI?=
 =?utf-8?B?eEs4dUpXVHcyRnJ1bWJvVGx4UnpNYVB0NzRndEJVWTVuNGdvVFNjeC9Uejkx?=
 =?utf-8?B?anp2N0o4dURGOWM2UGkxUXpLc0VmYUlxNWU5YnRQZlpZc2JpbGxQeG5pbUtM?=
 =?utf-8?B?ZForUVI5YkVBQ0JoNzhvOGFvd0xvNm5wMFYwQm5vTGlpd1JZV2NwZy93OGpO?=
 =?utf-8?B?Q20xeXNKZU9lZUE1NGFUTUVWZHBGd04vU1NENCt3a0JYN0w0STlQV0ozVmFK?=
 =?utf-8?B?aDY2b3hlOUErSEpNQ2VYejR1U2wyVmd5bEE5MXoxYmc1QWtxSUo2QlM4VTZw?=
 =?utf-8?B?cTJieVluR0F2Yi9mY1RLNDl3OFFrMzNFbk9PYlplSG9pUUFRejR6b1ZXelZs?=
 =?utf-8?B?YU9OaVU4MjBWZ1pLNEliYzJIQnNBRGJUNkxIdTZDakppVkNWUERKMXl6c2Jz?=
 =?utf-8?B?MkdTc3Fxc1ZXQW5UYkE3L0xWY2pyZGVwbUJNbzREUWxOZnMvRVZOa3JDT3No?=
 =?utf-8?B?RzdOUXpQNTh0YmxCR2pyakwyTmFCQWZuZjl1TVRPU2haWWdJb2NBeHlJakp1?=
 =?utf-8?B?WEhXdDErMnl3MndoYXp2eDdFYndVNGZDUzgyWWYySGxQRnRYckczYmtjemZ0?=
 =?utf-8?B?U0hHcExWSXRvNHpteDhNZDZMQlV6N2NFMU1SUGovYU9PeXg3bEJUTHF1dmNT?=
 =?utf-8?B?L2pzNUJPcktaUmZMWS94UmJUQTdmejM2OXg5RU9BNis2eTF4bHpVS29EWUJv?=
 =?utf-8?Q?wScbX43RYN1kxx5vNnR5Qwq9PJbbePCqKufWU=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98380a80-8475-42bd-d4a0-08d937f63277
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3158.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2021 16:27:59.9861
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yhHlLdYNQLELtZsniEaOqfPUCwBRscPRefFboIj+ua/ouGpZ8OaMpTaq+uU2uwuOFFmJ6sL3dB9Fkg1J8ZNHVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3494
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10026 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 mlxscore=0
 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2106250097
X-Proofpoint-ORIG-GUID: pzG_rpbPbSNlNCoKg2C4WXULFwyje7mt
X-Proofpoint-GUID: pzG_rpbPbSNlNCoKg2C4WXULFwyje7mt
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jason,

On 25/06/2021 08.03, Jason Gunthorpe wrote:
> On Thu, Jun 24, 2021 at 11:55:31AM -0700, Gerd Rausch wrote:
>> Fix a memory leak when "rmda_resolve_route" is called
>> more than once on the same "rdma_cm_id".
>>
>> Signed-off-by: Gerd Rausch <gerd.rausch@oracle.com>
>> ---
>>  drivers/infiniband/core/cma.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> I wondered for a while if it would be better to clear this in
> cma_query_handler(), but it seems this is OK
> 
> Applied to for-next
> 

Thank you, I appreciate it.

  Gerd