Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ELF: add and use SUPRESS_WARN_UNUSED_RESULT
To:     Alexey Dobriyan <adobriyan@gmail.com>,
        Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Miguel Ojeda <ojeda@kernel.org>
References: <YNYz+hVeqsQmiEqN@localhost.localdomain>
 <CANiq72=qtAcsyReu85AVT-cSf3dcvbnTpQYEF1JhxCRP0WgHUw@mail.gmail.com>
 <YNZGNvGn/pkMhsx+@localhost.localdomain>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <1de70b4e-722e-3c42-1c1d-06d6d1334206@infradead.org>
Date:   Fri, 25 Jun 2021 14:11:39 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <YNZGNvGn/pkMhsx+@localhost.localdomain>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/25/21 2:10 PM, Alexey Dobriyan wrote:
> On Fri, Jun 25, 2021 at 10:34:29PM +0200, Miguel Ojeda wrote:
>> On Fri, Jun 25, 2021 at 9:52 PM Alexey Dobriyan <adobriyan@gmail.com> wrote:
>>>
>>> +/*
>>> + * "(void)" is enough for clang but not for gcc.
>>> + */
>>> +#define SUPRESS_WARN_UNUSED_RESULT     (void)!
>>
>> While it is related to the attribute, this macro is not an attribute,
>> so please add it somewhere else.
> 
> This is natural place. If you're supressing WUR, then the WUR macro
> itself is defined implying that the header has been included.
> 
>> By the way, the name has a typo.
> 
> Ha!
> 

as in Aha!?

s/SUPRESS/SUPPRESS/